Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FinancialLinks #517

Merged
merged 1 commit into from
Oct 28, 2017
Merged

Add FinancialLinks #517

merged 1 commit into from
Oct 28, 2017

Conversation

paroga
Copy link
Member

@paroga paroga commented Oct 13, 2017

For now this is only usefull for plugins, since there is no UI.

@paroga paroga force-pushed the fl branch 2 times, most recently from de8228e to f9438b0 Compare October 22, 2017 09:19
@wvengen
Copy link
Member

wvengen commented Oct 26, 2017

I'm curious to learn for what you'd be using this.

@paroga
Copy link
Member Author

paroga commented Oct 26, 2017

in the current form it's usefull for

  1. link two FinancialTransaction together (transfer money from one ordergroup to another ordergroup)
  2. sometimes members pay invoices directly during pickup at suppliers and we then "pay" them by adding money to the ordergroup
    with the FinacialLink it's now possible to view the details (and verify the transactions at a later time)

with #352 invoices and finacial_transactions can be linked to the corresponding transaction at the bank account

wvengen
wvengen approved these changes Oct 27, 2017
View reviewed changes
Copy link
Member

@wvengen wvengen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remark, but this feature is worth having already.

app/controllers/finance/financial_links_controller.rb
}
end
@items.sort_by! { |item| item[:date] }
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be expressed clearer. One thing is use map and +. Maybe the functionality of gathering standard info from a FinancialLink relation belongs in FinancialLink?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use the functions for generating the links, which is not available at the model.

@paroga
Add FinancialLinks
31e648b 
For now this is only usefull for plugins, since there is no UI.
@paroga paroga merged commit 53bb096 into foodcoops:master Oct 28, 2017
@paroga paroga deleted the fl branch October 28, 2017 18:17
@wvengen wvengen added this to the 4.6 milestone Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvengen wvengen wvengen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6
Development

Successfully merging this pull request may close these issues.
2 participants
@paroga @wvengen