Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish translation: first strings translated from English #525

Closed
wants to merge 4 commits into from

Conversation

acracia
Copy link
Contributor

@acracia acracia commented Nov 5, 2017

Ey hello:

Please review this translation file for Spanish, I will finish in these days. I would like to be able to show the demo in Spanish to my mates of the group...

@paroga
Copy link
Member

paroga commented Nov 5, 2017

Fist I'd like to thank you for your very valuable contribution to Foodsoft. It's very nice to hear of the Spanish community.

We use localapp for our translations. See https://www.localeapp.com/projects/4867/translations

It would be great if you could put your translation into localeapp and I'll import them for the upcoming 4.7 release next week.

Using a mixture of English and Spanish in es.yml raises problems, since we do not see which strings are still untranslated. Foodsoft has an automatic fallback to English if the Spanish string is missing.

IMHO we have two possible solutions: (1) translate ALL strings and import it into LocaleApp or (2) remove English strings from es.yml and import only Spanish strings.

@acracia
Copy link
Contributor Author

acracia commented Nov 5, 2017

Oh I see... good I thought it was a very bad way of doing it

I see some of the strings have been already translated to spanish also

I could delete the english keys, sure. After having a look at the currently translated ones, for consistency too...

@paroga
Copy link
Member

paroga commented Nov 5, 2017

AFAIK the spanish translations are unmaintained anyway at the moment. So feel free to replace the existing translations or adopt yours for consistency. Just let me know if I can help you somehow (beside translating the strings 😉)

@acracia
Copy link
Contributor Author

acracia commented Nov 6, 2017

OK, I have pushed here only the strings in Spanish, they are at
c96fd92 but I cannot see how to import them at localeapp, could you please have a look and then close this merge req?
Then I will have a look at the missing spanish translations and it would be great if i can demo the site to my group coming week 💃

@paroga
Copy link
Member

paroga commented Nov 6, 2017

Unfortunately import is only possible for admins, but I imported the file for you. LocalApp should know all of your translations now.

@acracia acracia closed this Nov 6, 2017
@acracia
Copy link
Contributor Author

acracia commented Nov 6, 2017

Ok, I have translated most of the stuff, do you think you could try to make the strings spread to the incomplete translations? I have the feeling some of the incomplete strings are already translated on some other file.
I have left some strings out because I cannot understand them without the context and practise of use.
Do you think it is possible to see a demo in Spanish somewhere? Thanks!

@paroga
Copy link
Member

paroga commented Nov 6, 2017

I've sent you a private mail with credentials for a demo instance. Please let us know, if you need some additional help (e.g. in finding some translations).

Thanks again for that valuable contribution!

@wvengen
Copy link
Member

wvengen commented Nov 6, 2017

Awesome, thank you @acracia (and @paroga for integrating the changes)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants