Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to create a new FinancialTransaction at a FinancialLink #815

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Add option to create a new FinancialTransaction at a FinancialLink #815

merged 2 commits into from
Feb 17, 2021

Conversation

paroga
Copy link
Member

@paroga paroga commented Feb 8, 2021

No description provided.

wvengen
wvengen reviewed Feb 12, 2021
View reviewed changes
Copy link
Member

@wvengen wvengen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd need to see this working in practice to fully get the idea, but looks ok from my perspective, with some notes.

app/controllers/finance/financial_links_controller.rb Show resolved Hide resolved
app/controllers/finance/financial_links_controller.rb Outdated Show resolved Hide resolved
@paroga paroga merged commit a30d0d4 into foodcoops:master Feb 17, 2021
@paroga paroga deleted the nfl branch February 17, 2021 12:52
@mjavurek
Copy link
Contributor

I really appreciate this feature, it saves a lot of time for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvengen wvengen wvengen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paroga @mjavurek @wvengen