Add/Improve financial_transaction_* endpoints #818
Conversation
There was a problem hiding this comment.
Good to see this expanded.
Part of me doubts between having separate classes and types endpoints vs. a single classes endpoint with embedded types. I don't use these features enough to be able to judge, but the current approach is the most basic / KISS approach, so let's do it (albeit in many cases one would get them both and do the joining client-side).
| def financial_transaction_type_name | ||
| object.financial_transaction_type.name | ||
| end | ||
|
|
There was a problem hiding this comment.
I wonder if we should add a nested financial_transaction_type object here, or keep it with id and name?
Indeed account name and IBAN wouldn't really make sense here, so then we'd need separate serialization variants, so perhaps this approach is the best.
There was a problem hiding this comment.
i had the same thoughts, end ended with the current code 😉
No description provided.