Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rubocop #844

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Add Rubocop #844

merged 2 commits into from
Mar 2, 2021

Conversation

paroga
Copy link
Member

@paroga paroga commented Mar 1, 2021

No description provided.

@paroga paroga force-pushed the rubocop branch 3 times, most recently from 01d85d9 to 5ad5ce8 Compare March 1, 2021 13:39
@paroga paroga requested a review from wvengen March 1, 2021 13:41
wvengen
wvengen reviewed Mar 1, 2021
View reviewed changes
Copy link
Member

@wvengen wvengen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!!
One comment, and the specs seem to fail (no, I didn't review all changes).

.rubocop_todo.yml Show resolved Hide resolved
@paroga paroga force-pushed the rubocop branch 2 times, most recently from 7bf8dcc to 878067c Compare March 1, 2021 14:46
@paroga
Copy link
Member Author

paroga commented Mar 1, 2021

i reduced this change to whitespace only, so that it should not change any behavior

@paroga paroga requested a review from wvengen March 1, 2021 15:00
wvengen
wvengen approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@wvengen wvengen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@paroga paroga merged commit ea2862f into foodcoops:master Mar 2, 2021
@paroga paroga deleted the rubocop branch March 2, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvengen wvengen wvengen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paroga @wvengen