Show instance name at login screen #957
Conversation
app/views/sessions/new.html.haml
Outdated
| @@ -4,7 +4,10 @@ | |||
| $('#nick').focus(); | |||
| }); | |||
|
|
|||
| - title t('.title') | |||
| - if FoodsoftConfig[:instance_name].present? | |||
| - title FoodsoftConfig[:instance_name] | |||
There was a problem hiding this comment.
why not FoodsoftConfig[:instance_name] || t('.title') to avoid duplication of the config access?
what's the benefit of instance_name over the already existing name?
There was a problem hiding this comment.
There is no benefit if every foodcoop changes their foodcoop's name at the configuration page. Actually a lot of foodcoops didn't do it. But maybe this is a special case at our hosting platform.
As you suggested it would be better to use FoodsoftConfig:[:name] to make it editable by users.
config/app_config.yml.SAMPLE
Outdated
| # Multi_coop example configuration | ||
| # In order to make this work set "multi_coop_install: true" | ||
| #anotherfoodcoop: | ||
| # <<: *defaults | ||
| # database: | ||
| # database: foodsoft_anotherfoodcoop | ||
| # instance_name: anotherfoodcoop |
There was a problem hiding this comment.
please move it to the other options like name, since it's not more or less special
There was a problem hiding this comment.
I think this options have to be outside the default configuration block to make it work.
kidhab
force-pushed
the
show_instance_name
branch
from
57f1b79 to
c508a3e
Compare
config/app_config.yml.SAMPLE
Outdated
| # Multi_coop example configuration | ||
| # In order to make this work set "multi_coop_install: true" | ||
| #anotherfoodcoop: | ||
| # <<: *defaults | ||
| # database: | ||
| # database: foodsoft_anotherfoodcoop | ||
|
|
There was a problem hiding this comment.
what's the benefit of adding this lines? IMO everything is already present in the file.
app/views/sessions/new.html.haml
Outdated
| @@ -4,7 +4,7 @@ | |||
| $('#nick').focus(); | |||
| }); | |||
|
|
|||
| - title t('.title') | |||
| - title FoodsoftConfig[:name] || t('.title') | |||
There was a problem hiding this comment.
I'm not really happy with this. I'd prefer to keep the t('.title') in some form on the login page and use something like t('.title', FoodSoftConfig[:name]) to pass the name to the translation file, but this will probably result in (too) long lines. what you think about just adding something like h2 FoodsoftConfig[:name] after the title?
There was a problem hiding this comment.
Done. Indeed it looks better now with a subtitle.
kidhab
force-pushed
the
show_instance_name
branch
from
c508a3e to
36dc095
Compare
kidhab
force-pushed
the
show_instance_name
branch
from
36dc095 to
33e3963
Compare
This commit is useful for multi_coop_installs. At the moment the login screen of every multi_coop instance looks the same.
It can happen that users log in to another instance because they mistyped the URL.
With this change to name of a foodsoft instance will be shown as the title of the login screen.