Skip to content

Commit

Permalink
Set Attr and related APIs as supported since Safari 1
Browse files Browse the repository at this point in the history
The difference between Safari 1 and 1.3 is of course not important, but
some assumption has to be made to fix localName/namespaceURI/prefix:
mdn#9561

Based on current Web IDL, the set of related APIs are:
- Document.createAttribute
- Document.createAttributeNS
- Element.attributes (a NamedNodeMap)
- Element.getAttributeNode
- Element.getAttributeNodeNS
- Element.setAttributeNode
- Element.setAttributeNodeNS
- Element.removeAttributeNode
- NamedNodeMap and all of its members

All can be found in the bindings of the revision tagged Safari 85:
https://trac.webkit.org/browser/webkit/trunk/WebCore/khtml/ecma/kjs_dom.lut.h?rev=4552

The only complication is Attr.localName/namespaceURI/prefix, which was
then on Node, but judging by the implementation they probably worked:
https://trac.webkit.org/browser/webkit/trunk/WebCore/khtml/dom/dom_node.cpp?rev=4552
  • Loading branch information
foolip committed Mar 23, 2021
1 parent 6ab576e commit c7d5327
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions api/Attr.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"notes": "This API was previously available on the <a href='https://developer.mozilla.org/docs/Web/API/Node'><code>Node</code></a> API."
},
"safari": {
"version_added": "1.3"
"version_added": "1"
},
"safari_ios": {
"version_added": "1"
Expand Down Expand Up @@ -185,7 +185,7 @@
"notes": "This API was previously available on the <a href='https://developer.mozilla.org/docs/Web/API/Node'><code>Node</code></a> API."
},
"safari": {
"version_added": "1.3"
"version_added": "1"
},
"safari_ios": {
"version_added": "1"
Expand Down Expand Up @@ -288,7 +288,7 @@
"notes": "This API was previously available on the <a href='https://developer.mozilla.org/docs/Web/API/Node'><code>Node</code></a> API."
},
"safari": {
"version_added": "1.3"
"version_added": "1"
},
"safari_ios": {
"version_added": "1"
Expand Down
12 changes: 6 additions & 6 deletions api/Element.json
Original file line number Diff line number Diff line change
Expand Up @@ -1297,7 +1297,7 @@
"version_added": "10.1"
},
"safari": {
"version_added": "1.3"
"version_added": "1"
},
"safari_ios": {
"version_added": "1"
Expand Down Expand Up @@ -3914,7 +3914,7 @@
"version_added": "≤12.1"
},
"safari": {
"version_added": "1.3"
"version_added": "1"
},
"safari_ios": {
"version_added": "1"
Expand Down Expand Up @@ -3962,7 +3962,7 @@
"version_added": "≤12.1"
},
"safari": {
"version_added": "1.3"
"version_added": "1"
},
"safari_ios": {
"version_added": "1"
Expand Down Expand Up @@ -6543,7 +6543,7 @@
"version_added": "≤12.1"
},
"safari": {
"version_added": "1.3"
"version_added": "1"
},
"safari_ios": {
"version_added": "1"
Expand Down Expand Up @@ -7963,7 +7963,7 @@
"version_added": "≤12.1"
},
"safari": {
"version_added": "1.3"
"version_added": "1"
},
"safari_ios": {
"version_added": "1"
Expand Down Expand Up @@ -8013,7 +8013,7 @@
"version_added": "≤12.1"
},
"safari": {
"version_added": "1.3"
"version_added": "1"
},
"safari_ios": {
"version_added": "1"
Expand Down

0 comments on commit c7d5327

Please sign in to comment.