This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Fix custom test for ProcessingInstruction API #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Both In any case, it wasn't a great example, because |
|
Earlier versions of Safari and Firefox aren't too happy about using We could use the example direct from MDN web docs as well! So long as we're not using |
foolip
approved these changes
Jun 3, 2021
foolip
added a commit
that referenced
this pull request
Jun 4, 2021
Notable changes: #1194 #1195 #1198 #1203 Added tests: api.GPUSupportedLimits api.GPUSupportedLimits.maxBindGroups api.GPUSupportedLimits.maxDynamicStorageBuffersPerPipelineLayout api.GPUSupportedLimits.maxDynamicUniformBuffersPerPipelineLayout api.GPUSupportedLimits.maxSampledTexturesPerShaderStage api.GPUSupportedLimits.maxSamplersPerShaderStage api.GPUSupportedLimits.maxStorageBufferBindingSize api.GPUSupportedLimits.maxStorageBuffersPerShaderStage api.GPUSupportedLimits.maxStorageTexturesPerShaderStage api.GPUSupportedLimits.maxTextureArrayLayers api.GPUSupportedLimits.maxTextureDimension1D api.GPUSupportedLimits.maxTextureDimension2D api.GPUSupportedLimits.maxTextureDimension3D api.GPUSupportedLimits.maxUniformBufferBindingSize api.GPUSupportedLimits.maxUniformBuffersPerShaderStage api.GPUSupportedLimits.maxVertexAttributes api.GPUSupportedLimits.maxVertexBufferArrayStride api.GPUSupportedLimits.maxVertexBuffers Removed tests: api.GPUAdapterLimits api.GPUAdapterLimits.maxBindGroups api.GPUAdapterLimits.maxDynamicStorageBuffersPerPipelineLayout api.GPUAdapterLimits.maxDynamicUniformBuffersPerPipelineLayout api.GPUAdapterLimits.maxSampledTexturesPerShaderStage api.GPUAdapterLimits.maxSamplersPerShaderStage api.GPUAdapterLimits.maxStorageBufferBindingSize api.GPUAdapterLimits.maxStorageBuffersPerShaderStage api.GPUAdapterLimits.maxStorageTexturesPerShaderStage api.GPUAdapterLimits.maxTextureArrayLayers api.GPUAdapterLimits.maxTextureDimension1D api.GPUAdapterLimits.maxTextureDimension2D api.GPUAdapterLimits.maxTextureDimension3D api.GPUAdapterLimits.maxUniformBufferBindingSize api.GPUAdapterLimits.maxUniformBuffersPerShaderStage api.GPUAdapterLimits.maxVertexAttributes api.GPUAdapterLimits.maxVertexBufferArrayStride api.GPUAdapterLimits.maxVertexBuffers
Merged
foolip
added a commit
that referenced
this pull request
Jun 4, 2021
Notable changes: #1194 #1195 #1198 #1203 Added tests: api.GPUSupportedLimits api.GPUSupportedLimits.maxBindGroups api.GPUSupportedLimits.maxDynamicStorageBuffersPerPipelineLayout api.GPUSupportedLimits.maxDynamicUniformBuffersPerPipelineLayout api.GPUSupportedLimits.maxSampledTexturesPerShaderStage api.GPUSupportedLimits.maxSamplersPerShaderStage api.GPUSupportedLimits.maxStorageBufferBindingSize api.GPUSupportedLimits.maxStorageBuffersPerShaderStage api.GPUSupportedLimits.maxStorageTexturesPerShaderStage api.GPUSupportedLimits.maxTextureArrayLayers api.GPUSupportedLimits.maxTextureDimension1D api.GPUSupportedLimits.maxTextureDimension2D api.GPUSupportedLimits.maxTextureDimension3D api.GPUSupportedLimits.maxUniformBufferBindingSize api.GPUSupportedLimits.maxUniformBuffersPerShaderStage api.GPUSupportedLimits.maxVertexAttributes api.GPUSupportedLimits.maxVertexBufferArrayStride api.GPUSupportedLimits.maxVertexBuffers Removed tests: api.GPUAdapterLimits api.GPUAdapterLimits.maxBindGroups api.GPUAdapterLimits.maxDynamicStorageBuffersPerPipelineLayout api.GPUAdapterLimits.maxDynamicUniformBuffersPerPipelineLayout api.GPUAdapterLimits.maxSampledTexturesPerShaderStage api.GPUAdapterLimits.maxSamplersPerShaderStage api.GPUAdapterLimits.maxStorageBufferBindingSize api.GPUAdapterLimits.maxStorageBuffersPerShaderStage api.GPUAdapterLimits.maxStorageTexturesPerShaderStage api.GPUAdapterLimits.maxTextureArrayLayers api.GPUAdapterLimits.maxTextureDimension1D api.GPUAdapterLimits.maxTextureDimension2D api.GPUAdapterLimits.maxTextureDimension3D api.GPUAdapterLimits.maxUniformBufferBindingSize api.GPUAdapterLimits.maxUniformBuffersPerShaderStage api.GPUAdapterLimits.maxVertexAttributes api.GPUAdapterLimits.maxVertexBufferArrayStride api.GPUAdapterLimits.maxVertexBuffers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the custom test for the
ProcessingInstructionAPI. When I initially wrote the custom test, I thought that it had to sayxml, when in fact, it was the exact opposite.