Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add runtime_value/runtime_validation validation type re:#29 #33

Merged
merged 1 commit into from
Mar 7, 2016

Conversation

andreineculau
Copy link
Member

reflected a bit on #29 and came up with an alternative solution based on validation types

ping @sstrigler @erikgustafson-klarna

< Content-Type: application/json
{
\"{{type}}\": \"runtime_validation\",
\"erlang\": \"{not_equal, {\\\"/body/{{runtime_validation}}\\\", false, true}}.\"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Elvis:

Line 177 is too long: "erlang": "{not_equal, {\"/body/{{runtime_validation}}\", false, true}}.".

@andreineculau andreineculau added this to the 1.5.0 milestone Feb 27, 2016
@andreineculau andreineculau force-pushed the runtime_validation branch 2 times, most recently from 03d4ddb to 1cfbb56 Compare February 27, 2016 16:45
@sstrigler
Copy link

In general I like the idea. 👍

@andreineculau
Copy link
Member Author

@andreineculau
Copy link
Member Author

added also a shell option, although not entirely fond of it since it has to return an "erlang string"

andreineculau added a commit that referenced this pull request Mar 7, 2016
add runtime_value/runtime_validation validation type re:#29
@andreineculau andreineculau merged commit aee78f0 into master Mar 7, 2016
@andreineculau andreineculau deleted the runtime_validation branch March 8, 2016 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants