refactor!: eliminate sdk codec dependency from remote mode #107
Conversation
dadamu
force-pushed
the
paul/SDK-72/eliminate-sdk-codec-in-remote-mode
branch
from
e7064a4 to
afd4cf8
Compare
| type EncodingConfigBuilder func() appparams.EncodingConfig | ||
|
|
||
| var ( | ||
| ModuleBasics = module.NewBasicManager( | ||
| auth.AppModuleBasic{}, | ||
| genutil.NewAppModuleBasic(genutiltypes.DefaultMessageValidator), | ||
| bank.AppModuleBasic{}, | ||
| capability.AppModuleBasic{}, | ||
| staking.AppModuleBasic{}, | ||
| mint.AppModuleBasic{}, | ||
| distr.AppModuleBasic{}, | ||
| gov.NewAppModuleBasic( | ||
| []govclient.ProposalHandler{ | ||
| paramsclient.ProposalHandler, | ||
| upgradeclient.LegacyProposalHandler, | ||
| upgradeclient.LegacyCancelProposalHandler, | ||
| }, | ||
| ), | ||
| params.AppModuleBasic{}, | ||
| crisis.AppModuleBasic{}, | ||
| slashing.AppModuleBasic{}, | ||
| feegrantmodule.AppModuleBasic{}, | ||
| upgrade.AppModuleBasic{}, | ||
| evidence.AppModuleBasic{}, | ||
| authzmodule.AppModuleBasic{}, | ||
| groupmodule.AppModuleBasic{}, | ||
| vesting.AppModuleBasic{}, | ||
| nftmodule.AppModuleBasic{}, | ||
| consensus.AppModuleBasic{}, | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Remove it, the Codec should be manually defined by users who wants to use local mode node.
| @@ -49,7 +48,7 @@ type Database interface { | |||
|
|
|||
| // SaveMessage stores a single message. | |||
| // An error is returned if the operation fails. | |||
| SaveMessage(msg *types.Message) error | |||
| SaveMessage(height int64, txHash string, msg types.Message, addresses []string) error | |||
There was a problem hiding this comment.
Message is unmarshaled from TxBody which does not contain height, txHash and addresses information, so I change the interface to include them.
|
@0x7u Thanks for the review!
Currently, Cosmos-SDK handles the data in ProtoBuffer format. In addition, Codec is the encoder/decoder for ProtoBuffer, which is responsible to decode the raw data in ProtoBuffer format into the golang structure. This document tells more information. Currently, in order to transform all the message from ProtoBuffer into JSON to store inside
The structure/layout is following the Cosmos-SDK spec. Although the original structure is based on ProtoBuffer, so some |
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> ## Description <!-- Small description --> This PR eliminate the codec dependency from remote node to make Juno chain-agnostic. ## Checklist - [x] Targeted PR against correct branch. - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [x] Re-reviewed `Files changed` in the Github PR explorer.
Description
This PR eliminate the codec dependency from remote node to make Juno chain-agnostic.
Checklist
Files changedin the Github PR explorer.