fix: init command build empty config file #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiccardoM
suggested changes
Feb 7, 2024
types/config/config.go
Outdated
| @@ -49,7 +50,7 @@ func DefaultConfig() Config { | |||
| } | |||
|
|
|||
| func (c Config) GetBytes() ([]byte, error) { | |||
| return c.bytes, nil | |||
| return yaml.Marshal(c) | |||
There was a problem hiding this comment.
This will break everything when using the GetBytes method on other projects. Instead, we should fix the initialization inside the DefaultConfig if the problem is there
RiccardoM
approved these changes
Feb 7, 2024
RiccardoM
changed the title
RiccardoM
pushed a commit
that referenced
this pull request
Mar 27, 2024
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> ## Description <!-- Small description --> This PR intends to fix the init command building empty config instead of the default config since `bytes` value of `DefaultConfig` built by constructor is `nil`. ## Checklist - [x] Targeted PR against correct branch. - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [x] Re-reviewed `Files changed` in the Github PR explorer.
dzmitryhil
pushed a commit
to CoreumFoundation/junov5
that referenced
this pull request
Dec 16, 2024
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> ## Description <!-- Small description --> This PR intends to fix the init command building empty config instead of the default config since `bytes` value of `DefaultConfig` built by constructor is `nil`. ## Checklist - [x] Targeted PR against correct branch. - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [x] Re-reviewed `Files changed` in the Github PR explorer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to fix the init command building empty config instead of the default config since
bytesvalue ofDefaultConfigbuilt by constructor isnil.Checklist
Files changedin the Github PR explorer.