Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ChainID() method for getting the chain ID from node status #69

Merged
merged 1 commit into from
Jul 5, 2022
Merged

feat: add ChainID() method for getting the chain ID from node status #69

merged 1 commit into from
Jul 5, 2022

Conversation

huichiaotsou
Copy link
Contributor

@huichiaotsou huichiaotsou commented Jun 28, 2022 •
edited
Loading

Description

For getting chain ID, replace querying genesis with querying status as querying genesis is heavy and may put much load on the node which is unnecessary, especially when the app crashed and restarted.

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Re-reviewed Files changed in the Github PR explorer.

@huichiaotsou huichiaotsou requested a review from MonikaCat June 28, 2022 06:23
MonikaCat
MonikaCat approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@MonikaCat MonikaCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, LGTM

@MonikaCat MonikaCat added the automerge Automatically merge PR once all prerequisites pass label Jul 5, 2022
@MonikaCat MonikaCat requested a review from RiccardoM July 5, 2022 06:53
@mergify mergify bot merged commit 88a8bc2 into cosmos/v0.44.x Jul 5, 2022
@mergify mergify bot deleted the aaron/chain_id branch July 5, 2022 06:57
RiccardoM pushed a commit that referenced this pull request Jul 27, 2022
@huichiaotsou @RiccardoM
feat: add ChainID() method for getting the chain ID from node status (#…
8893968 
…69)

## Description


For getting `chain ID`, replace `querying genesis` with `querying status` as `querying genesis` is heavy and may put much load on the node which is unnecessary, especially when the app crashed and restarted. 

## Checklist
- [ ] Targeted PR against correct branch.
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Wrote unit tests.  
- [ ] Re-reviewed `Files changed` in the Github PR explorer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonikaCat MonikaCat MonikaCat approved these changes

@RiccardoM RiccardoM RiccardoM approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huichiaotsou @RiccardoM @MonikaCat