-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve block parsing starting height calculations #72
Merged
mergify
merged 21 commits into
cosmos/v0.44.x
from
BDU-489-start-height-default-on-bdjuno
Sep 2, 2022
Merged
feat: improve block parsing starting height calculations #72
mergify
merged 21 commits into
cosmos/v0.44.x
from
BDU-489-start-height-default-on-bdjuno
Sep 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aaron <76254323+huichiaotsou@users.noreply.github.com>
huichiaotsou
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested LGTM
RiccardoM
reviewed
Sep 1, 2022
RiccardoM
changed the title
feat: updated missing blocks parsing
feat: improve block parsing starting height calculations
Sep 1, 2022
Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
RiccardoM
reviewed
Sep 1, 2022
RiccardoM
approved these changes
Sep 2, 2022
RiccardoM
pushed a commit
that referenced
this pull request
Sep 2, 2022
## Description Fixes [BDU-489](https://forbole.atlassian.net/browse/BDU-489) ## Checklist - [x] Targeted PR against correct branch. - [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [x] Re-reviewed `Files changed` in the Github PR explorer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes BDU-489
Checklist
Files changed
in the Github PR explorer.