Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve block parsing starting height calculations #72

Merged
merged 21 commits into from
Sep 2, 2022

Conversation

MonikaCat
Copy link
Contributor

@MonikaCat MonikaCat commented Aug 26, 2022

Description

Fixes BDU-489

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Re-reviewed Files changed in the Github PR explorer.

@MonikaCat MonikaCat added the automerge Automatically merge PR once all prerequisites pass label Aug 26, 2022
@MonikaCat MonikaCat requested a review from huichiaotsou August 26, 2022 12:14
cmd/start/cmd.go Outdated Show resolved Hide resolved
Co-authored-by: Aaron <76254323+huichiaotsou@users.noreply.github.com>
@MonikaCat MonikaCat requested a review from huichiaotsou August 29, 2022 06:51
Copy link
Contributor

@huichiaotsou huichiaotsou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested LGTM

@MonikaCat MonikaCat requested a review from RiccardoM August 29, 2022 07:29
cmd/start/cmd.go Outdated Show resolved Hide resolved
cmd/parse/blocks/blocks.go Outdated Show resolved Hide resolved
cmd/start/cmd.go Outdated Show resolved Hide resolved
cmd/start/cmd.go Outdated Show resolved Hide resolved
@RiccardoM RiccardoM changed the title feat: updated missing blocks parsing feat: improve block parsing starting height calculations Sep 1, 2022
@MonikaCat MonikaCat requested a review from RiccardoM September 1, 2022 10:32
@MonikaCat MonikaCat requested a review from RiccardoM September 1, 2022 12:32
@mergify mergify bot merged commit d752cdb into cosmos/v0.44.x Sep 2, 2022
@mergify mergify bot deleted the BDU-489-start-height-default-on-bdjuno branch September 2, 2022 05:39
RiccardoM pushed a commit that referenced this pull request Sep 2, 2022
## Description
Fixes [BDU-489](https://forbole.atlassian.net/browse/BDU-489)
## Checklist
- [x] Targeted PR against correct branch.
- [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Wrote unit tests.  
- [x] Re-reviewed `Files changed` in the Github PR explorer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants