fix: return 0 height inside GetLastBlockHeight if there are no blocks #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huichiaotsou
added
the
automerge
RiccardoM
reviewed
Sep 16, 2022
There was a problem hiding this comment.
I'm not sure about this change honestly. Wouldn't it make more sense to have the GetLastBlockHeight method return maybe 0 instead of an error if there are no blocks? I mean, if there are no blocks stored inside the database, 0 makes sense as the last block height (since blocks start from 1 and 0 means no blocks).
cool I changed the |
huichiaotsou
changed the title
return err with log.Error() for GetLastBlockHeight() in parse blocks cmdGetLastBlockHeight() method while no block is saved
RiccardoM
changed the title
GetLastBlockHeight() method while no block is savedGetLastBlockHeight() if there are no blocks
RiccardoM
changed the title
GetLastBlockHeight() if there are no blocks
RiccardoM
approved these changes
Sep 19, 2022
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 19, 2022
…e no blocks" (#78) ## Description fix #76 I forgot to remove this section of codes lol ## Checklist - [ ] Targeted PR against correct branch. - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [ ] Re-reviewed `Files changed` in the Github PR explorer.
RiccardoM
pushed a commit
that referenced
this pull request
Sep 20, 2022
…#76) When we use the parse blocks command, in case that the database is empty, `return err` here will error out the program and not continuing parsing the desired block height. Replacing it here so it's more handy for dev purpose when we need to just test specific heights. (we don't have to run ` start cmd` before using `parse blocks all`) - [x] Targeted PR against correct branch. - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [x] Re-reviewed `Files changed` in the Github PR explorer.
RiccardoM
pushed a commit
that referenced
this pull request
Sep 20, 2022
…e no blocks" (#78) ## Description fix #76 I forgot to remove this section of codes lol ## Checklist - [ ] Targeted PR against correct branch. - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [ ] Re-reviewed `Files changed` in the Github PR explorer.
MonikaCat
pushed a commit
that referenced
this pull request
Jan 19, 2024
…#76) When we use the parse blocks command, in case that the database is empty, `return err` here will error out the program and not continuing parsing the desired block height. Replacing it here so it's more handy for dev purpose when we need to just test specific heights. (we don't have to run ` start cmd` before using `parse blocks all`) - [x] Targeted PR against correct branch. - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [x] Re-reviewed `Files changed` in the Github PR explorer.
MonikaCat
pushed a commit
that referenced
this pull request
Jan 19, 2024
…e no blocks" (#78) ## Description fix #76 I forgot to remove this section of codes lol ## Checklist - [ ] Targeted PR against correct branch. - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [ ] Re-reviewed `Files changed` in the Github PR explorer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we use the parse blocks command, in case that the database is empty,
return errhere will error out the program and not continuing parsing the desired block height. Replacing it here so it's more handy for dev purpose when we need to just test specific heights. (we don't have to runstart cmdbefore usingparse blocks all)Checklist
Files changedin the Github PR explorer.