-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump github.com/tendermint/tendermint from v0.34.21 to v0.34.22 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the `PostgreSQL` database to use the sqlx driver instead of `sql` to provide more functionalities while maintaining backward compatibility - [x] Targeted PR against correct branch. - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [x] Re-reviewed `Files changed` in the Github PR explorer.
This PR updates the linting process to use the `golangci-lint` CLI. This should guarantee major forward compatibility as the golangci-lint version is now tracked within the codebase along with other dependencies Depends-On: #79 - [x] Targeted PR against correct branch. - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [x] Re-reviewed `Files changed` in the Github PR explorer.
…ing (#74) Fixes [BDU-542](https://forbole.atlassian.net/browse/BDU-542) - [x] Targeted PR against correct branch. - [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [x] Re-reviewed `Files changed` in the Github PR explorer.
RiccardoM
force-pushed
the
riccardom/bump-tendermint
branch
from
November 23, 2022 17:12
e72dc4e
to
6b88fb0
Compare
RiccardoM
requested review from
huichiaotsou and
MonikaCat
and removed request for
huichiaotsou
November 23, 2022 17:26
MonikaCat
reviewed
Nov 24, 2022
MonikaCat
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested, LGTM
Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
huichiaotsou
approved these changes
Nov 24, 2022
RiccardoM
added a commit
that referenced
this pull request
Nov 24, 2022
…0.34.22 (#83) This PR bumps Tendermint to `v0.34.22` removing the need to replace the default dependency thanks to the newly added support for `https` websocket URLs directlty inside Tendermint Core. - [x] Targeted PR against correct branch. - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [x] Re-reviewed `Files changed` in the Github PR explorer.
MonikaCat
pushed a commit
that referenced
this pull request
Jan 19, 2024
…0.34.22 (#83) This PR bumps Tendermint to `v0.34.22` removing the need to replace the default dependency thanks to the newly added support for `https` websocket URLs directlty inside Tendermint Core. - [x] Targeted PR against correct branch. - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [x] Re-reviewed `Files changed` in the Github PR explorer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps Tendermint to
v0.34.22
removing the need to replace the default dependency thanks to the newly added support forhttps
websocket URLs directlty inside Tendermint Core.Checklist
Files changed
in the Github PR explorer.