feat: decode IBC transfer data object to JSON for MsgRecvPacket
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cosmos/v0.45.x-akash
MonikaCat
changed the title
MsgRecvPacket MsgRecvPacket
RiccardoM
approved these changes
Apr 6, 2023
MonikaCat
added a commit
that referenced
this pull request
Aug 31, 2023
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> ## Description <!-- Small description --> Fixes [BDU-894](https://forbole.atlassian.net/jira/software/c/projects/BDU/issues/BDU-894) and [BDU-446](https://forbole.atlassian.net/jira/software/c/projects/BDU/issues/BDU-446) Changes: - Decode transfer `data` object to JSON, append it to the message and store it inside `message` table for `/ibc.core.channel.v1.MsgRecvPacket` ## Checklist - [x] Targeted PR against correct branch. - [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [x] Re-reviewed `Files changed` in the Github PR explorer. [BDU-894]: https://forbole.atlassian.net/browse/BDU-894?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [BDU-446]: https://forbole.atlassian.net/browse/BDU-446?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> Co-authored-by: Mai Quang Hiep <maiquanghiepdl@gmail.com>
MonikaCat
added a commit
that referenced
this pull request
Jan 3, 2024
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> ## Description <!-- Small description --> Fixes [BDU-894](https://forbole.atlassian.net/jira/software/c/projects/BDU/issues/BDU-894) and [BDU-446](https://forbole.atlassian.net/jira/software/c/projects/BDU/issues/BDU-446) Changes: - Decode transfer `data` object to JSON, append it to the message and store it inside `message` table for `/ibc.core.channel.v1.MsgRecvPacket` ## Checklist - [x] Targeted PR against correct branch. - [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [x] Re-reviewed `Files changed` in the Github PR explorer. [BDU-894]: https://forbole.atlassian.net/browse/BDU-894?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [BDU-446]: https://forbole.atlassian.net/browse/BDU-446?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> Co-authored-by: Mai Quang Hiep <maiquanghiepdl@gmail.com>
MonikaCat
added a commit
that referenced
this pull request
Jan 19, 2024
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> ## Description <!-- Small description --> Fixes [BDU-894](https://forbole.atlassian.net/jira/software/c/projects/BDU/issues/BDU-894) and [BDU-446](https://forbole.atlassian.net/jira/software/c/projects/BDU/issues/BDU-446) Changes: - Decode transfer `data` object to JSON, append it to the message and store it inside `message` table for `/ibc.core.channel.v1.MsgRecvPacket` ## Checklist - [x] Targeted PR against correct branch. - [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [x] Re-reviewed `Files changed` in the Github PR explorer. [BDU-894]: https://forbole.atlassian.net/browse/BDU-894?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [BDU-446]: https://forbole.atlassian.net/browse/BDU-446?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> Co-authored-by: Mai Quang Hiep <maiquanghiepdl@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes BDU-894 and BDU-446
Changes:
dataobject to JSON, append it to the message and store it insidemessagetable for/ibc.core.channel.v1.MsgRecvPacketChecklist
Files changedin the Github PR explorer.