Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Updates to KPI options #23

Merged
merged 9 commits into from
Jul 16, 2020
Merged

ENH: Updates to KPI options #23

merged 9 commits into from
Jul 16, 2020

Conversation

flongford
Copy link
Contributor

@flongford flongford commented Jun 25, 2020

Implements enhancements that take into account to updates to both KPISpecification and BaseOptimizerEngine classes introduced in force-h2020/force-bdss#353

The IOptimizer classes now don't have to deal with converting the raw KPI values into the objective score - all of this is dealt with by BaseOptimizerEngine._score

To Do:

Notes:

  • It does not seem appropriate to use 'infinite' upper bounds for any KPI. Ideally the user should always specify upper bounds.

  • Nevergrad's MultiobjectiveFunction currently deals with non-specified upper_bounds attributes by performing a few non-biased calculations of the objective function and identifying the largest values that are generated for each output variable (https://github.com/facebookresearch/nevergrad/blob/master/nevergrad/functions/multiobjective/core.py#L51).

  • This is an 'all-or-nothing' approach, however - it will only perform this estimation if no upper_bounds array is passed into the constructor. Therefore it cannot handle certain KPIs with upper bounds set and others without (as currently allowed by the BDSS framework)

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #23 into master will increase coverage by 0.59%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   98.47%   99.06%   +0.59%     
==========================================
  Files           7        7              
  Lines         197      215      +18     
  Branches       32       34       +2     
==========================================
+ Hits          194      213      +19     
  Misses          2        2              
+ Partials        1        0       -1     
Impacted Files Coverage Δ
force_nevergrad/engine/parameter_translation.py 96.36% <ø> (-0.07%) ⬇️
force_nevergrad/engine/nevergrad_optimizers.py 100.00% <100.00%> (+1.85%) ⬆️
force_nevergrad/mco/ng_mco.py 100.00% <100.00%> (ø)
force_nevergrad/mco/ng_mco_model.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4024d8...09bde2d. Read the comment docs.

@flongford flongford marked this pull request as draft June 25, 2020 16:42
@flongford flongford marked this pull request as ready for review July 8, 2020 17:14
@sparsonslab
Copy link
Contributor

I've played around with it on the two-Gaussian example, using various lower/upper ranges (negative, positive, narrow, wide). The engine is still running and the Pareto-front is where is should be, certainly with a wide range. I'm not sure in theory what behaviour it should cause in other cases but it does seem to be having some effects.

@flongford flongford merged commit 093b5ee into master Jul 16, 2020
@flongford flongford deleted the enh/kpi-updates branch July 16, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants