@W-14913383 | Fix e2e pipeline #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuanchen-S
previously approved these changes
Jan 30, 2024
kalagarraj
reviewed
Jan 31, 2024
.github/workflows/e2etest.yml
Outdated
| @@ -1,61 +1,61 @@ | |||
| name: e2e-tests | |||
|
|
|||
| on: | |||
| pull_request: | |||
There was a problem hiding this comment.
there are so many changes due to formatting, can u describe the actual change
There was a problem hiding this comment.
@kalagarraj Sure, thank you for asking. In the step "Auth Devhub" I have just changed
echo ${{ env.DEVHUB_AUTH }} > authFile
sf force auth sfdxurl store -f 'authFile'
to
echo '${{ env.DEVHUB_AUTH }}' > authFile
sf force auth sfdxurl store -f authFile
this fixed the inconsistency happened in some PR's where the authFile was not read correctly.
kalagarraj
reviewed
Jan 31, 2024
.github/workflows/e2etest.yml
Outdated
| PR_NUMBER: ${{ github.event.pull_request.number }} | ||
| steps: | ||
| - name: Checkout |
There was a problem hiding this comment.
something is not correct in new formatting... did u use any linter or IDE to reformat?
this new one has 8 spaces where as the old one had 4 spaces for indentation. I think u might consider moving back to 4 spaces for indentation
cw112233
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Trying to fix the e2e test
@W-14913383@