Bump vscode dependency to 1.23 #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When we do any manual testing we have been using 1.23.x so I'm less worried about any fallout from this. It does mean that unless users update to 1.23, they won't be able to get the new goodness -- which is fine since we need to do this soon anyway. |
DatGuyJonathan
approved these changes
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Webview Panels in VS Code are only available in version 1.23 and higher.
To support custom UI we need to be able to use webview panels.
I separated this from #451 to make it clearer than this is a version bump.
What issues does this PR fix or reference?
@W-5013822@