Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support interfaces in Records #266

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Support interfaces in Records #266

merged 1 commit into from
Nov 8, 2022

Conversation

gastaldi
Copy link
Member

@gastaldi gastaldi commented Nov 5, 2022

@gastaldi
Copy link
Member Author

gastaldi commented Nov 5, 2022

@pcimcioch can you give this PR a try and let me know if that works for you?

@gastaldi gastaldi requested a review from lincolnthree November 5, 2022 14:43
@pcimcioch
Copy link

I've built it locally and it seems to be working. I didn't test it very thoroughly, but it seems to cover my case nicely

@gastaldi gastaldi merged commit 24729b8 into master Nov 8, 2022
@gastaldi gastaldi deleted the record_interfaces branch November 8, 2022 00:44
@gastaldi
Copy link
Member Author

gastaldi commented Nov 8, 2022

I'll merge and release this one meanwhile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lincolnthree lincolnthree Awaiting requested review from lincolnthree

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support interface implementation in records
2 participants
@gastaldi @pcimcioch