feat: route storage

formancehq · Oct 18, 2024 · 1b94951 · 1b94951
1 parent 5b63f49
commit 1b94951
Show file tree

Hide file tree

Showing 48 changed files with 277 additions and 604 deletions.
diff --git a/internal/api/v2/common.go b/internal/api/v2/common.go
@@ -25,45 +25,53 @@ func getPITOOTFilter(r *http.Request) (*ledgercontroller.PITFilter, error) {
 	pitString := r.URL.Query().Get("endTime")
 	ootString := r.URL.Query().Get("startTime")
 
-	pit := time.Time{}
-	oot := time.Time{}
+	var (
+		pit *time.Time
+		oot *time.Time
+	)
 
 	if pitString != "" {
 		var err error
-		pit, err = time.ParseTime(pitString)
+		_pit, err := time.ParseTime(pitString)
 		if err != nil {
 			return nil, err
 		}
+
+		pit = &_pit
 	}
 
 	if ootString != "" {
 		var err error
-		oot, err = time.ParseTime(ootString)
+		_oot, err := time.ParseTime(ootString)
 		if err != nil {
 			return nil, err
 		}
+
+		oot = &_oot
 	}
 
 	return &ledgercontroller.PITFilter{
-		PIT: &pit,
-		OOT: &oot,
+		PIT: pit,
+		OOT: oot,
 	}, nil
 }
 
 func getPITFilter(r *http.Request) (*ledgercontroller.PITFilter, error) {
 	pitString := r.URL.Query().Get("pit")
 
-	pit := time.Time{}
+	var pit *time.Time
 	if pitString != "" {
 		var err error
-		pit, err = time.ParseTime(pitString)
+		_pit, err := time.ParseTime(pitString)
 		if err != nil {
 			return nil, err
 		}
+
+		pit = &_pit
 	}
 
 	return &ledgercontroller.PITFilter{
-		PIT: &pit,
+		PIT: pit,
 	}, nil
 }
 

diff --git a/internal/api/v2/controllers_volumes_test.go b/internal/api/v2/controllers_volumes_test.go
@@ -34,15 +34,13 @@ func TestGetVolumes(t *testing.T) {
 		expectedErrorCode string
 	}
 	before := time.Now()
-	zero := time.Time{}
 
 	testCases := []testCase{
 		{
 			name: "basic",
 			expectQuery: ledgercontroller.NewPaginatedQueryOptions(ledgercontroller.FiltersForVolumes{
 				PITFilter: ledgercontroller.PITFilter{
 					PIT: &before,
-					OOT: &zero,
 				},
 
 				UseInsertionDate: false,
@@ -55,7 +53,6 @@ func TestGetVolumes(t *testing.T) {
 			expectQuery: ledgercontroller.NewPaginatedQueryOptions(ledgercontroller.FiltersForVolumes{
 				PITFilter: ledgercontroller.PITFilter{
 					PIT: &before,
-					OOT: &zero,
 				},
 			}).
 				WithQueryBuilder(query.Match("metadata[roles]", "admin")).
@@ -67,7 +64,6 @@ func TestGetVolumes(t *testing.T) {
 			expectQuery: ledgercontroller.NewPaginatedQueryOptions(ledgercontroller.FiltersForVolumes{
 				PITFilter: ledgercontroller.PITFilter{
 					PIT: &before,
-					OOT: &zero,
 				},
 			}).
 				WithQueryBuilder(query.Match("account", "foo")).
@@ -88,7 +84,6 @@ func TestGetVolumes(t *testing.T) {
 			expectQuery: ledgercontroller.NewPaginatedQueryOptions(ledgercontroller.FiltersForVolumes{
 				PITFilter: ledgercontroller.PITFilter{
 					PIT: &before,
-					OOT: &zero,
 				},
 				GroupLvl: 3,
 			}).WithPageSize(DefaultPageSize),
@@ -99,7 +94,6 @@ func TestGetVolumes(t *testing.T) {
 			expectQuery: ledgercontroller.NewPaginatedQueryOptions(ledgercontroller.FiltersForVolumes{
 				PITFilter: ledgercontroller.PITFilter{
 					PIT: &before,
-					OOT: &zero,
 				},
 			}).WithPageSize(DefaultPageSize).WithQueryBuilder(query.Exists("metadata", "foo")),
 		},
@@ -109,7 +103,6 @@ func TestGetVolumes(t *testing.T) {
 			expectQuery: ledgercontroller.NewPaginatedQueryOptions(ledgercontroller.FiltersForVolumes{
 				PITFilter: ledgercontroller.PITFilter{
 					PIT: &before,
-					OOT: &zero,
 				},
 			}).WithQueryBuilder(query.Gte("balance[EUR]", float64(50))).
 				WithPageSize(DefaultPageSize),

diff --git a/internal/storage/bucket/old/11-drop-triggers.sql b/internal/storage/bucket/old/11-drop-triggers.sql
diff --git a/internal/storage/bucket/old/12-moves-add-transaction-id.sql b/internal/storage/bucket/old/12-moves-add-transaction-id.sql
diff --git a/internal/storage/bucket/old/13-set-transaction-timestamp-default-utc.sql b/internal/storage/bucket/old/13-set-transaction-timestamp-default-utc.sql
diff --git a/internal/storage/bucket/old/14-rename-address-moves-column.sql b/internal/storage/bucket/old/14-rename-address-moves-column.sql
diff --git a/internal/storage/bucket/old/15-moves-remove-accounts-seq.sql b/internal/storage/bucket/old/15-moves-remove-accounts-seq.sql
diff --git a/internal/storage/bucket/old/16-transactions-fix-reference.sql b/internal/storage/bucket/old/16-transactions-fix-reference.sql
diff --git a/internal/storage/bucket/old/17-transactions-add-pvc.sql b/internal/storage/bucket/old/17-transactions-add-pvc.sql
diff --git a/internal/storage/bucket/old/18-logs-add-idempotency-hash.sql b/internal/storage/bucket/old/18-logs-add-idempotency-hash.sql
diff --git a/internal/storage/bucket/old/19-moves-drop-accounts-address-array.sql b/internal/storage/bucket/old/19-moves-drop-accounts-address-array.sql
diff --git a/internal/storage/bucket/old/20-add-accounts-volumes-table.sql b/internal/storage/bucket/old/20-add-accounts-volumes-table.sql
diff --git a/internal/storage/bucket/old/21-transactions-metadata-add-transaction-id.sql b/internal/storage/bucket/old/21-transactions-metadata-add-transaction-id.sql
diff --git a/internal/storage/bucket/old/22-accounts-metadata-add-address.sql b/internal/storage/bucket/old/22-accounts-metadata-add-address.sql
diff --git a/internal/storage/bucket/old/23-transactions-clean-table.sql b/internal/storage/bucket/old/23-transactions-clean-table.sql
diff --git a/internal/storage/bucket/old/24-accounts-set-array-not-null.sql b/internal/storage/bucket/old/24-accounts-set-array-not-null.sql
diff --git a/internal/storage/bucket/old/25-logs-set-hash-nullable.sql b/internal/storage/bucket/old/25-logs-set-hash-nullable.sql
diff --git a/internal/storage/bucket/old/26-clean-index.sql b/internal/storage/bucket/old/26-clean-index.sql