fix: mapping ignore destinations accounts

formancehq · Apr 17, 2023 · 32fde57 · 32fde57
1 parent 991b720
commit 32fde57
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 0 deletions.
diff --git a/pkg/ledger/execute_script_test.go b/pkg/ledger/execute_script_test.go
@@ -42,6 +42,42 @@ func TestCompilationError(t *testing.T) {
 	})
 }
 
+func TestMappingIgnoreDestinations(t *testing.T) {
+	runOnLedger(func(l *ledger.Ledger) {
+		script := core.ScriptData{
+			Script: core.Script{
+				Plain: `
+					send [USD/2 1100] (
+						source = @A allowing overdraft up to [USD/2 1100]
+						destination = @B
+					)`,
+			},
+		}
+		_, err := l.ExecuteScript(context.Background(), false, script)
+		require.NoError(t, err)
+
+		_, err = l.ExecuteTxsData(context.Background(), false, core.TransactionData{
+			Postings: []core.Posting{{
+				Source:      "B",
+				Destination: "A",
+				Amount:      core.NewMonetaryInt(100),
+				Asset:       "USD/2",
+			}},
+		})
+		require.NoError(t, err)
+
+		_, err = l.ExecuteTxsData(context.Background(), false, core.TransactionData{
+			Postings: []core.Posting{{
+				Source:      "B",
+				Destination: "A",
+				Amount:      core.NewMonetaryInt(0),
+				Asset:       "USD/2",
+			}},
+		})
+		require.NoError(t, err)
+	})
+}
+
 func TestSend(t *testing.T) {
 	runOnLedger(func(l *ledger.Ledger) {
 		t.Run("nominal", func(t *testing.T) {

diff --git a/pkg/ledger/execute_txsdata.go b/pkg/ledger/execute_txsdata.go
@@ -114,6 +114,9 @@ func (l *Ledger) ExecuteTxsData(ctx context.Context, preview bool, txsData ...co
 				if account == core.WORLD {
 					continue
 				}
+				if volume.Balance().Gte(txVolumeAggr.PreCommitVolumes[account][asset].Balance()) {
+					continue
+				}
 
 				for _, contract := range contracts {
 					if contract.Match(account) {