feat: factorize error handling on api

internal/api/common/errors.go

@@ -0,0 +1,17 @@
+package common
+
+import (
+	"errors"
+	"github.com/formancehq/go-libs/api"
+	"github.com/formancehq/go-libs/platform/postgres"
+	"net/http"
+)
+
+func HandleCommonErrors(w http.ResponseWriter, r *http.Request, err error) {
+	switch {
+	case errors.Is(err, postgres.ErrTooManyClient{}):
+		api.WriteErrorResponse(w, http.StatusServiceUnavailable, api.ErrorInternal, err)
+	default:
+		api.InternalServerError(w, r, err)
+	}
+}

internal/api/v1/controllers_accounts_add_metadata.go

@@ -2,7 +2,6 @@ package v1
 
 import (
 	"encoding/json"
-	"github.com/formancehq/go-libs/platform/postgres"
 	"github.com/formancehq/ledger/internal/controller/ledger"
 	"github.com/formancehq/ledger/pkg/accounts"
 	"net/http"
@@ -39,12 +38,7 @@ func addAccountMetadata(w http.ResponseWriter, r *http.Request) {
 		Metadata: m,
 	}))
 	if err != nil {
-		switch {
-		case errors.Is(err, postgres.ErrTooManyClient{}):
-			api.WriteErrorResponse(w, http.StatusServiceUnavailable, api.ErrorInternal, err)
-		default:
-			api.InternalServerError(w, r, err)
-		}
+		common.HandleCommonErrors(w, r, err)
 		return
 	}
 

internal/api/v1/controllers_accounts_count.go

@@ -2,7 +2,6 @@ package v1
 
 import (
 	"fmt"
-	"github.com/formancehq/go-libs/platform/postgres"
 	"net/http"
 
 	"errors"
@@ -35,12 +34,10 @@ func countAccounts(w http.ResponseWriter, r *http.Request) {
 	count, err := l.CountAccounts(r.Context(), *query)
 	if err != nil {
 		switch {
-		case errors.Is(err, postgres.ErrTooManyClient{}):
-			api.WriteErrorResponse(w, http.StatusServiceUnavailable, api.ErrorInternal, err)
 		case errors.Is(err, ledgercontroller.ErrInvalidQuery{}) || errors.Is(err, ledgercontroller.ErrMissingFeature{}):
 			api.BadRequest(w, ErrValidation, err)
 		default:
-			api.InternalServerError(w, r, err)
+			common.HandleCommonErrors(w, r, err)
 		}
 		return
 	}

internal/api/v1/controllers_accounts_delete_metadata.go

@@ -1,8 +1,6 @@
 package v1
 
 import (
-	"errors"
-	"github.com/formancehq/go-libs/platform/postgres"
 	"github.com/formancehq/ledger/internal/controller/ledger"
 	"net/http"
 	"net/url"
@@ -27,12 +25,7 @@ func deleteAccountMetadata(w http.ResponseWriter, r *http.Request) {
 				Key:     chi.URLParam(r, "key"),
 			}),
 		); err != nil {
-		switch {
-		case errors.Is(err, postgres.ErrTooManyClient{}):
-			api.WriteErrorResponse(w, http.StatusServiceUnavailable, api.ErrorInternal, err)
-		default:
-			api.InternalServerError(w, r, err)
-		}
+		common.HandleCommonErrors(w, r, err)
 		return
 	}
 

internal/api/v1/controllers_accounts_list.go

@@ -1,7 +1,6 @@
 package v1
 
 import (
-	"github.com/formancehq/go-libs/platform/postgres"
 	"net/http"
 
 	"errors"
@@ -34,12 +33,10 @@ func listAccounts(w http.ResponseWriter, r *http.Request) {
 	cursor, err := l.ListAccounts(r.Context(), *query)
 	if err != nil {
 		switch {
-		case errors.Is(err, postgres.ErrTooManyClient{}):
-			api.WriteErrorResponse(w, http.StatusServiceUnavailable, api.ErrorInternal, err)
 		case errors.Is(err, ledgercontroller.ErrMissingFeature{}):
 			api.BadRequest(w, ErrValidation, err)
 		default:
-			api.InternalServerError(w, r, err)
+			common.HandleCommonErrors(w, r, err)
 		}
 		return
 	}

internal/api/v1/controllers_accounts_read.go

@@ -1,7 +1,6 @@
 package v1
 
 import (
-	"errors"
 	"net/http"
 	"net/url"
 
@@ -29,8 +28,6 @@ func getAccount(w http.ResponseWriter, r *http.Request) {
 	acc, err := l.GetAccount(r.Context(), query)
 	if err != nil {
 		switch {
-		case errors.Is(err, postgres.ErrTooManyClient{}):
-			api.WriteErrorResponse(w, http.StatusServiceUnavailable, api.ErrorInternal, err)
 		case postgres.IsNotFoundError(err):
 			acc = &ledger.Account{
 				Address:          address,
@@ -39,7 +36,7 @@ func getAccount(w http.ResponseWriter, r *http.Request) {
 				EffectiveVolumes: ledger.VolumesByAssets{},
 			}
 		default:
-			api.InternalServerError(w, r, err)
+			common.HandleCommonErrors(w, r, err)
 			return
 		}
 	}

internal/api/v1/controllers_balances_aggregates.go

@@ -1,8 +1,6 @@
 package v1
 
 import (
-	"errors"
-	"github.com/formancehq/go-libs/platform/postgres"
 	"net/http"
 
 	"github.com/formancehq/go-libs/api"
@@ -39,12 +37,7 @@ func getBalancesAggregated(w http.ResponseWriter, r *http.Request) {
 
 	balances, err := common.LedgerFromContext(r.Context()).GetAggregatedBalances(r.Context(), query)
 	if err != nil {
-		switch {
-		case errors.Is(err, postgres.ErrTooManyClient{}):
-			api.WriteErrorResponse(w, http.StatusServiceUnavailable, api.ErrorInternal, err)
-		default:
-			api.InternalServerError(w, r, err)
-		}
+		common.HandleCommonErrors(w, r, err)
 		return
 	}
 

internal/api/v1/controllers_balances_list.go

@@ -1,8 +1,6 @@
 package v1
 
 import (
-	"errors"
-	"github.com/formancehq/go-libs/platform/postgres"
 	"math/big"
 	"net/http"
 
@@ -34,12 +32,7 @@ func getBalances(w http.ResponseWriter, r *http.Request) {
 
 	cursor, err := l.ListAccounts(r.Context(), q.WithExpandVolumes())
 	if err != nil {
-		switch {
-		case errors.Is(err, postgres.ErrTooManyClient{}):
-			api.WriteErrorResponse(w, http.StatusServiceUnavailable, api.ErrorInternal, err)
-		default:
-			api.InternalServerError(w, r, err)
-		}
+		common.HandleCommonErrors(w, r, err)
 		return
 	}
 

internal/api/v1/controllers_config.go

@@ -3,6 +3,7 @@ package v1
 import (
 	"context"
 	_ "embed"
+	"github.com/formancehq/ledger/internal/api/common"
 	"net/http"
 
 	ledgercontroller "github.com/formancehq/ledger/internal/controller/ledger"
@@ -46,7 +47,7 @@ func getInfo(systemController system.Controller, version string) func(w http.Res
 				return nil
 			},
 		); err != nil {
-			api.InternalServerError(w, r, err)
+			common.HandleCommonErrors(w, r, err)
 			return
 		}
 

internal/api/v1/controllers_info.go

@@ -1,8 +1,6 @@
 package v1
 
 import (
-	"errors"
-	"github.com/formancehq/go-libs/platform/postgres"
 	"net/http"
 
 	"github.com/go-chi/chi/v5"
@@ -31,12 +29,7 @@ func getLedgerInfo(w http.ResponseWriter, r *http.Request) {
 	}
 	res.Storage.Migrations, err = ledger.GetMigrationsInfo(r.Context())
 	if err != nil {
-		switch {
-		case errors.Is(err, postgres.ErrTooManyClient{}):
-			api.WriteErrorResponse(w, http.StatusServiceUnavailable, api.ErrorInternal, err)
-		default:
-			api.InternalServerError(w, r, err)
-		}
+		common.HandleCommonErrors(w, r, err)
 		return
 	}
 

internal/api/v1/controllers_logs_list.go

@@ -1,9 +1,7 @@
 package v1
 
 import (
-	"errors"
 	"fmt"
-	"github.com/formancehq/go-libs/platform/postgres"
 	"net/http"
 
 	"github.com/formancehq/go-libs/api"
@@ -75,12 +73,7 @@ func getLogs(w http.ResponseWriter, r *http.Request) {
 
 	cursor, err := l.ListLogs(r.Context(), query)
 	if err != nil {
-		switch {
-		case errors.Is(err, postgres.ErrTooManyClient{}):
-			api.WriteErrorResponse(w, http.StatusServiceUnavailable, api.ErrorInternal, err)
-		default:
-			api.InternalServerError(w, r, err)
-		}
+		common.HandleCommonErrors(w, r, err)
 		return
 	}
 

internal/api/v1/controllers_stats.go

@@ -1,8 +1,6 @@
 package v1
 
 import (
-	"errors"
-	"github.com/formancehq/go-libs/platform/postgres"
 	"net/http"
 
 	"github.com/formancehq/go-libs/api"
@@ -14,12 +12,7 @@ func getStats(w http.ResponseWriter, r *http.Request) {
 
 	stats, err := l.GetStats(r.Context())
 	if err != nil {
-		switch {
-		case errors.Is(err, postgres.ErrTooManyClient{}):
-			api.WriteErrorResponse(w, http.StatusServiceUnavailable, api.ErrorInternal, err)
-		default:
-			api.InternalServerError(w, r, err)
-		}
+		common.HandleCommonErrors(w, r, err)
 		return
 	}
 

internal/api/v1/controllers_transactions_add_metadata.go

@@ -2,7 +2,6 @@ package v1
 
 import (
 	"encoding/json"
-	"github.com/formancehq/go-libs/platform/postgres"
 	"net/http"
 	"strconv"
 
@@ -35,12 +34,10 @@ func addTransactionMetadata(w http.ResponseWriter, r *http.Request) {
 		Metadata:      m,
 	})); err != nil {
 		switch {
-		case errors.Is(err, postgres.ErrTooManyClient{}):
-			api.WriteErrorResponse(w, http.StatusServiceUnavailable, api.ErrorInternal, err)
 		case errors.Is(err, ledgercontroller.ErrNotFound):
 			api.NotFound(w, err)
 		default:
-			api.InternalServerError(w, r, err)
+			common.HandleCommonErrors(w, r, err)
 		}
 		return
 	}

internal/api/v1/controllers_transactions_count.go

@@ -1,9 +1,7 @@
 package v1
 
 import (
-	"errors"
 	"fmt"
-	"github.com/formancehq/go-libs/platform/postgres"
 	"net/http"
 
 	"github.com/formancehq/go-libs/api"
@@ -27,12 +25,7 @@ func countTransactions(w http.ResponseWriter, r *http.Request) {
 	count, err := common.LedgerFromContext(r.Context()).
 		CountTransactions(r.Context(), ledgercontroller.NewListTransactionsQuery(*options))
 	if err != nil {
-		switch {
-		case errors.Is(err, postgres.ErrTooManyClient{}):
-			api.WriteErrorResponse(w, http.StatusServiceUnavailable, api.ErrorInternal, err)
-		default:
-			api.InternalServerError(w, r, err)
-		}
+		common.HandleCommonErrors(w, r, err)
 		return
 	}
 

internal/api/v1/controllers_transactions_create.go

@@ -3,7 +3,6 @@ package v1
 import (
 	"encoding/json"
 	"fmt"
-	"github.com/formancehq/go-libs/platform/postgres"
 	"math/big"
 	"net/http"
 
@@ -87,8 +86,6 @@ func createTransaction(w http.ResponseWriter, r *http.Request) {
 		res, err := l.CreateTransaction(r.Context(), getCommandParameters(r, common.TxToScriptData(txData, false)))
 		if err != nil {
 			switch {
-			case errors.Is(err, postgres.ErrTooManyClient{}):
-				api.WriteErrorResponse(w, http.StatusServiceUnavailable, api.ErrorInternal, err)
 			case errors.Is(err, &ledgercontroller.ErrInsufficientFunds{}):
 				api.BadRequest(w, ErrInsufficientFund, err)
 			case errors.Is(err, &ledgercontroller.ErrInvalidVars{}) || errors.Is(err, ledgercontroller.ErrCompilationFailed{}):
@@ -101,7 +98,7 @@ func createTransaction(w http.ResponseWriter, r *http.Request) {
 			case errors.Is(err, ledgercontroller.ErrTransactionReferenceConflict{}):
 				api.WriteErrorResponse(w, http.StatusConflict, ErrConflict, err)
 			default:
-				api.InternalServerError(w, r, err)
+				common.HandleCommonErrors(w, r, err)
 			}
 			return
 		}
@@ -125,8 +122,6 @@ func createTransaction(w http.ResponseWriter, r *http.Request) {
 	res, err := l.CreateTransaction(r.Context(), getCommandParameters(r, runScript))
 	if err != nil {
 		switch {
-		case errors.Is(err, postgres.ErrTooManyClient{}):
-			api.WriteErrorResponse(w, http.StatusServiceUnavailable, api.ErrorInternal, err)
 		case errors.Is(err, &ledgercontroller.ErrInsufficientFunds{}):
 			api.BadRequest(w, ErrInsufficientFund, err)
 		case errors.Is(err, &ledgercontroller.ErrInvalidVars{}) ||
@@ -138,7 +133,7 @@ func createTransaction(w http.ResponseWriter, r *http.Request) {
 		case errors.Is(err, ledgercontroller.ErrTransactionReferenceConflict{}):
 			api.WriteErrorResponse(w, http.StatusConflict, ErrConflict, err)
 		default:
-			api.InternalServerError(w, r, err)
+			common.HandleCommonErrors(w, r, err)
 		}
 		return
 	}

internal/api/v1/controllers_transactions_delete_metadata.go

@@ -1,7 +1,6 @@
 package v1
 
 import (
-	"github.com/formancehq/go-libs/platform/postgres"
 	"net/http"
 	"strconv"
 
@@ -29,12 +28,10 @@ func deleteTransactionMetadata(w http.ResponseWriter, r *http.Request) {
 		Key:           metadataKey,
 	})); err != nil {
 		switch {
-		case errors.Is(err, postgres.ErrTooManyClient{}):
-			api.WriteErrorResponse(w, http.StatusServiceUnavailable, api.ErrorInternal, err)
 		case errors.Is(err, ledgercontroller.ErrNotFound):
 			api.NotFound(w, err)
 		default:
-			api.InternalServerError(w, r, err)
+			common.HandleCommonErrors(w, r, err)
 		}
 		return
 	}