Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add a logger #66

Closed
henry-jackson opened this issue Nov 20, 2021 · 1 comment
Closed

Feature request: Add a logger #66

henry-jackson opened this issue Nov 20, 2021 · 1 comment
Labels
enhancement New feature or request RFC

Comments

@henry-jackson
Copy link
Contributor

Summary
Provide structured, levelled logging to improve the dev experience of numary - first suggested by Alex K in this comment here. This allows allows for additional control over what is logged in the future.

Solution proposal
Implement leveled logging with zap. Also, clean up places around the app where if viper.GetBool("debug"), and replace with debug level logs.

An example of providing an Fx app with a logger (and specifically zap) is shown here in the Fx docs .

Describe alternatives you've considered
Other popular logging packages, such as logrus, could be used instead. Zap seems to be a natural fit for an Fx app but I'm not attached to the idea.

@henry-jackson henry-jackson added enhancement New feature or request RFC labels Nov 20, 2021
@gfyrag
Copy link
Contributor

gfyrag commented Jan 27, 2022

Hello @henry-jackson
The PR #142 should address this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request RFC
Projects
None yet
Development

No branches or pull requests

2 participants