Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/num 293 ledger make logger configurable #142

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

gfyrag
Copy link
Contributor

@gfyrag gfyrag commented Jan 27, 2022

  • Add logging package.
  • Inject logger in all services requiring it.

@gfyrag gfyrag requested a review from a team as a code owner January 27, 2022 15:21
@gfyrag gfyrag requested a review from djimnz January 27, 2022 15:21
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #142 (4d60a3e) into main (a33d4f1) will increase coverage by 7.33%.
The diff coverage is 71.15%.

❗ Current head 4d60a3e differs from pull request most recent head 89f5f70. Consider uploading reports for the commit 89f5f70 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   66.85%   74.19%   +7.33%     
==========================================
  Files          73       76       +3     
  Lines        2589     2798     +209     
==========================================
+ Hits         1731     2076     +345     
+ Misses        713      572     -141     
- Partials      145      150       +5     
Impacted Files Coverage Δ
pkg/config/config.go 0.00% <0.00%> (ø)
pkg/core/asset.go 100.00% <ø> (ø)
pkg/storage/remember_config.go 0.00% <0.00%> (ø)
pkg/storage/sqlstorage/aggregations.go 91.66% <ø> (-0.12%) ⬇️
pkg/storage/sqlstorage/mapping.go 75.92% <ø> (-0.44%) ⬇️
pkg/logging/logger.go 4.08% <4.08%> (ø)
pkg/api/controllers/account_controller.go 73.33% <20.00%> (+70.05%) ⬆️
pkg/api/controllers/mapping_controller.go 57.14% <40.00%> (+51.08%) ⬆️
pkg/api/controllers/transaction_controller.go 60.22% <43.58%> (+49.70%) ⬆️
pkg/api/controllers/ledger_controller.go 66.66% <50.00%> (+54.90%) ⬆️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5072124...89f5f70. Read the comment docs.

@gfyrag gfyrag force-pushed the feature/num-293-ledger-make-logger-configurable branch from 73e59cf to 310e265 Compare January 31, 2022 15:53
@gfyrag gfyrag force-pushed the feature/num-293-ledger-make-logger-configurable branch from 310e265 to 89f5f70 Compare January 31, 2022 16:01
@gfyrag gfyrag merged commit 683db8e into main Jan 31, 2022
@gfyrag gfyrag deleted the feature/num-293-ledger-make-logger-configurable branch January 31, 2022 16:15
flemzord pushed a commit that referenced this pull request Jun 7, 2023
flemzord pushed a commit that referenced this pull request Sep 20, 2023
flemzord pushed a commit that referenced this pull request Dec 4, 2023
flemzord pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants