Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some error types in ledger package and respond with 4xx status on transaction endpoint. #128

Merged
merged 3 commits into from
Jan 19, 2022

Conversation

gfyrag
Copy link
Contributor

@gfyrag gfyrag commented Jan 18, 2022

No description provided.

@gfyrag gfyrag requested a review from a team as a code owner January 18, 2022 15:42
@gfyrag gfyrag requested a review from djimnz January 18, 2022 15:42
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #128 (61d2ec5) into main (4a337a9) will decrease coverage by 0.46%.
The diff coverage is 18.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   69.75%   69.29%   -0.47%     
==========================================
  Files          68       69       +1     
  Lines        2255     2273      +18     
==========================================
+ Hits         1573     1575       +2     
- Misses        565      580      +15     
- Partials      117      118       +1     
Impacted Files Coverage Δ
pkg/api/controllers/transaction_controller.go 10.52% <0.00%> (-1.02%) ⬇️
pkg/ledger/ledger.go 74.28% <28.57%> (-1.61%) ⬇️
pkg/ledger/error.go 55.55% <55.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d79996c...61d2ec5. Read the comment docs.

@flemzord flemzord merged commit 9c03790 into main Jan 19, 2022
@flemzord flemzord deleted the feature/num-289-handle-ledger-status-code-remove-500 branch January 19, 2022 09:32
flemzord pushed a commit that referenced this pull request Jun 7, 2023
flemzord pushed a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants