Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add accounts filtering on address or metadata #185

Merged

Conversation

gfyrag
Copy link
Contributor

@gfyrag gfyrag commented Apr 4, 2022

  • Add account filtering.
  • Fix total on transactions count.
  • Add filtering on account metadata.
  • Add metadata filtering at api level and fix tests...
  • Complete swagger.

@gfyrag gfyrag requested a review from a team as a code owner April 4, 2022 15:02
@gfyrag gfyrag requested review from flemzord and removed request for a team April 4, 2022 15:02
@gfyrag gfyrag force-pushed the feature/num-443-ledger-allow-to-filter-accounts-using-a branch from 636569b to b57ffb5 Compare April 4, 2022 17:59
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #185 (4d6e621) into main (62f28fb) will increase coverage by 9.71%.
The diff coverage is 77.77%.

❗ Current head 4d6e621 differs from pull request most recent head d49a84b. Consider uploading reports for the commit d49a84b to get more accurate results

@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   59.27%   68.98%   +9.71%     
==========================================
  Files          81       81              
  Lines        3565     3660      +95     
==========================================
+ Hits         2113     2525     +412     
+ Misses       1259      922     -337     
- Partials      193      213      +20     
Impacted Files Coverage Δ
internal/pgtesting/testing.go 86.95% <ø> (+60.86%) ⬆️
pkg/storage/sqlstorage/mapping.go 80.00% <ø> (+5.00%) ⬆️
pkg/core/transaction.go 66.66% <33.33%> (ø)
pkg/api/internal/testing.go 89.68% <50.00%> (+67.94%) ⬆️
pkg/storage/sqlstorage/sqlite.go 63.93% <56.09%> (+44.88%) ⬆️
pkg/storage/sqlstorage/driver.go 60.00% <62.50%> (+1.37%) ⬆️
pkg/ledger/ledger.go 78.00% <77.77%> (+9.20%) ⬆️
pkg/storage/sqlstorage/schema.go 83.67% <80.00%> (-0.95%) ⬇️
cmd/server_start.go 75.75% <86.66%> (+9.09%) ⬆️
pkg/core/metadata.go 76.19% <87.50%> (+8.74%) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d480e...d49a84b. Read the comment docs.

@gfyrag gfyrag force-pushed the feature/num-443-ledger-allow-to-filter-accounts-using-a branch from b57ffb5 to ff6a0a8 Compare April 4, 2022 18:14
@gfyrag gfyrag merged commit 68b417c into main Apr 7, 2022
@gfyrag gfyrag deleted the feature/num-443-ledger-allow-to-filter-accounts-using-a branch April 7, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant