fix/gin middleware #206
Merged
fix/gin middleware #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gfyrag
commented
May 17, 2022
gfyrag
commented
- Add a workflow to automatically build docker images for special meaning branch like : * feature/XXX * features/XXX * feat/XXX * fix/XXX * hotfix/XXX
- Fix release pipeline.
- Fix scope handling. The http context of the authenticated request was not properly forward to the next handlers. So, even if the request was authenticated, the next handlers doesn't see actual scopes of the agent.
…ng branch like : * feature/XXX * features/XXX * feat/XXX * fix/XXX * hotfix/XXX
Codecov Report
@@ Coverage Diff @@
## main #206 +/- ##
==========================================
- Coverage 66.37% 66.33% -0.04%
==========================================
Files 70 70
Lines 3533 3535 +2
==========================================
Hits 2345 2345
- Misses 968 970 +2
Partials 220 220
Continue to review full report at Codecov.
|
flemzord
approved these changes
May 17, 2022
| tags: ghcr.io/numary/ledger:${{ github.sha }} | ||
| build-args: | | ||
| APP_SHA=${{ github.sha }} | ||
| VERSION=${{ github.sha }} |
There was a problem hiding this comment.
I think add 'SEGMENT_WRITE_KEY' ?
The http context of the authenticated request was not properly forward to the next handlers. So, even if the request was authenticated, the next handlers doesn't see actual scopes of the agent.
gfyrag
force-pushed
the
fix/gin-middleware
branch
from
06fd304
to
cda88e0
Compare
flemzord
pushed a commit
that referenced
this pull request
Jun 7, 2023
flemzord
pushed a commit
that referenced
this pull request
Sep 20, 2023
flemzord
pushed a commit
that referenced
this pull request
Dec 4, 2023
flemzord
pushed a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.