NUM-384 filters account by their balance #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #217 +/- ##
==========================================
+ Coverage 67.16% 67.62% +0.45%
==========================================
Files 72 72
Lines 3816 3870 +54
==========================================
+ Hits 2563 2617 +54
Misses 1001 1001
Partials 252 252
Continue to review full report at Codecov.
|
jdupas22
force-pushed
the
num-384-filter-accounts-by-balance
branch
from
f805184
to
e7f5dd9
Compare
jdupas22
requested review from
louhde,
gfyrag and
antoinegelloz
and removed request for
a team
antoinegelloz
suggested changes
Jun 7, 2022
jdupas22
force-pushed
the
num-384-filter-accounts-by-balance
branch
from
e26a3c3
to
0da6ddf
Compare
|
@antoinegelloz @gfyrag maybe we try to merge #216 before this one ? |
Yes we could :) Did you have a look at it already? |
|
@all-contributors please add @jdupas22 for code |
|
I've put up a pull request to add @jdupas22! 🎉 |
gfyrag
reviewed
Jun 9, 2022
gfyrag
reviewed
Jun 14, 2022
gfyrag
reviewed
Jun 14, 2022
gfyrag
previously approved these changes
Jun 14, 2022
jdupas22
force-pushed
the
num-384-filter-accounts-by-balance
branch
4 times, most recently
from
010cf49
to
e0235ee
Compare
gfyrag
previously approved these changes
Jun 15, 2022
feat(api_test): add unit tests for balance filtering in get accounts controller refactor(accounts_balance_filter): convert balance into integer during db request for sqlite, and replace balance_operator if workflow by a switch case feat(accounts_balance_filter): add parameter validation in controller, panics if parameters are bad in storage, and few fixes in the tests feat(accounts_balance_filter): fix missing return after responseError in controller, and various test improvements refactor(accounts_controller): rename constants in camel case to be more standard refactor(query): dissolve query package into storage, and better handling of enum BalanceOperator
jdupas22
force-pushed
the
num-384-filter-accounts-by-balance
branch
from
e0235ee
to
6986f0b
Compare
antoinegelloz
previously approved these changes
Jun 16, 2022
antoinegelloz
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows us to filters the accounts we get using the /{ledger}/accounts route by their balance
The request now takes two more optionnal parameters, and <balance_operator>
I also tried to make the tests easier to read by bracketing them