Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General refactoring before NUM-556 #230

Merged
merged 4 commits into from
Jun 21, 2022
Merged

General refactoring before NUM-556 #230

merged 4 commits into from
Jun 21, 2022

Conversation

antoinegelloz
Copy link
Contributor

No description provided.

@antoinegelloz antoinegelloz requested a review from a team as a code owner June 20, 2022 08:01
@antoinegelloz antoinegelloz requested review from louhde and removed request for a team June 20, 2022 08:01
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #230 (534fb83) into main (b11fa82) will increase coverage by 0.43%.
The diff coverage is 90.76%.

❗ Current head 534fb83 differs from pull request most recent head 67740a2. Consider uploading reports for the commit 67740a2 to get more accurate results

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
+ Coverage   67.16%   67.59%   +0.43%     
==========================================
  Files          72       73       +1     
  Lines        3816     3861      +45     
==========================================
+ Hits         2563     2610      +47     
+ Misses       1001      999       -2     
  Partials      252      252              
Impacted Files Coverage Δ
pkg/ledger/ledger.go 70.90% <83.33%> (-6.06%) ⬇️
pkg/ledger/process.go 84.21% <84.21%> (ø)
pkg/storage/sqlstorage/transactions.go 82.03% <84.61%> (ø)
pkg/api/controllers/transaction_controller.go 65.03% <87.93%> (ø)
pkg/storage/sqlstorage/accounts.go 84.40% <91.48%> (+3.94%) ⬆️
pkg/api/controllers/account_controller.go 75.55% <92.00%> (+5.69%) ⬆️
pkg/api/controllers/config_controller.go 45.71% <100.00%> (ø)
pkg/core/log.go 82.50% <100.00%> (ø)
pkg/core/volumes.go 85.18% <100.00%> (-1.49%) ⬇️
pkg/ledger/executor.go 61.64% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee9102d...67740a2. Read the comment docs.

louhde
louhde previously approved these changes Jun 20, 2022
gfyrag
gfyrag previously approved these changes Jun 20, 2022
@altitude altitude requested a review from gfyrag June 20, 2022 14:07
flemzord
flemzord previously approved these changes Jun 21, 2022
Base automatically changed from add-new-transactions-tests to main June 21, 2022 13:05
@antoinegelloz antoinegelloz requested a review from a team as a code owner June 21, 2022 13:05
@antoinegelloz antoinegelloz dismissed stale reviews from flemzord, gfyrag, and louhde via 67740a2 June 21, 2022 13:26
@antoinegelloz antoinegelloz merged commit d62d8a3 into main Jun 21, 2022
@antoinegelloz antoinegelloz deleted the refactoring branch June 21, 2022 13:49
antoinegelloz pushed a commit that referenced this pull request Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants