Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve readme #258

Merged
merged 1 commit into from
Jul 5, 2022
Merged

chore: improve readme #258

merged 1 commit into from
Jul 5, 2022

Conversation

altitude
Copy link
Member

Signed-off-by: Clément Salaün salaun.clement@gmail.com

Title

Just improving the readme

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Technical debt

What parts of the code are impacted ?

None

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Clément Salaün <salaun.clement@gmail.com>
@flemzord flemzord changed the title fix: improve readme chore: improve readme Jun 30, 2022
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #258 (0c82d6f) into main (1f813f6) will decrease coverage by 0.93%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
- Coverage   70.82%   69.88%   -0.94%     
==========================================
  Files          75       75              
  Lines        3938     3938              
==========================================
- Hits         2789     2752      -37     
- Misses        906      944      +38     
+ Partials      243      242       -1     
Impacted Files Coverage Δ
pkg/ledgertesting/storage.go 50.00% <0.00%> (-30.56%) ⬇️
pkg/storage/sqlstorage/flavor.go 34.04% <0.00%> (-19.15%) ⬇️
internal/pgtesting/testing.go 73.91% <0.00%> (-13.05%) ⬇️
pkg/core/posting.go 68.00% <0.00%> (-8.00%) ⬇️
pkg/storage/sqlstorage/mapping.go 79.48% <0.00%> (-7.70%) ⬇️
pkg/core/volumes.go 77.77% <0.00%> (-7.41%) ⬇️
pkg/core/metadata.go 71.42% <0.00%> (-4.77%) ⬇️
pkg/storage/sqlstorage/accounts.go 84.03% <0.00%> (-1.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f813f6...0c82d6f. Read the comment docs.

@flemzord flemzord merged commit c4f3c93 into main Jul 5, 2022
@flemzord flemzord deleted the altitude-patch-2 branch July 5, 2022 08:57
flemzord pushed a commit that referenced this pull request Jun 7, 2023
flemzord pushed a commit that referenced this pull request Sep 20, 2023
flemzord pushed a commit that referenced this pull request Dec 4, 2023
flemzord pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants