Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support Linux in ARM64 & Improvement for CI #282

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

flemzord
Copy link
Member

@flemzord flemzord commented Jul 15, 2022

Add support Linux in ARM64

  • Simplify of the Github Action Workflows
  • Added "-tags netgo" flag to force the use of the NET lib in GO and not via the LIBC

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Technical debt

What parts of the code are impacted ?

Build process.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #282 (2b3f88f) into main (a6c1a6d) will increase coverage by 0.33%.
The diff coverage is 84.78%.

❗ Current head 2b3f88f differs from pull request most recent head 78c506c. Consider uploading reports for the commit 78c506c to get more accurate results

@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
+ Coverage   71.19%   71.53%   +0.33%     
==========================================
  Files          78       79       +1     
  Lines        4180     4222      +42     
==========================================
+ Hits         2976     3020      +44     
+ Misses        942      932      -10     
- Partials      262      270       +8     
Impacted Files Coverage Δ
pkg/ledger/resolver.go 84.21% <ø> (-1.28%) ⬇️
pkg/storage/storage.go 55.22% <ø> (ø)
pkg/storage/sqlstorage/accounts.go 83.73% <66.66%> (-1.98%) ⬇️
pkg/api/controllers/balance_controller.go 75.92% <70.00%> (-2.80%) ⬇️
pkg/storage/sqlstorage/balances.go 77.67% <70.00%> (-1.96%) ⬇️
pkg/api/controllers/transaction_controller.go 92.63% <75.00%> (-1.52%) ⬇️
pkg/storage/sqlstorage/transactions.go 85.79% <91.66%> (-0.08%) ⬇️
pkg/api/controllers/account_controller.go 88.11% <100.00%> (+0.88%) ⬆️
pkg/api/controllers/query.go 100.00% <100.00%> (ø)
pkg/storage/accounts.go 100.00% <100.00%> (+11.76%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6c1a6d...78c506c. Read the comment docs.

@flemzord flemzord force-pushed the feat/add_support_linux_arm64 branch from 2759bb5 to 81eaf9a Compare July 15, 2022 19:19
runs-on: ubuntu-latest
services:
postgres:
image: postgres:13-alpine
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the lastest stable postgres version is 14, should we upgrade the tests?

@flemzord flemzord merged commit fa5e13e into main Jul 18, 2022
@flemzord flemzord deleted the feat/add_support_linux_arm64 branch July 18, 2022 09:31
flemzord added a commit that referenced this pull request Jul 18, 2022
flemzord pushed a commit that referenced this pull request Sep 20, 2023
Signed-off-by: jdupas22 <106673437+jdupas22@users.noreply.github.com>
flemzord pushed a commit that referenced this pull request Dec 4, 2023
Signed-off-by: jdupas22 <106673437+jdupas22@users.noreply.github.com>
flemzord pushed a commit that referenced this pull request Sep 25, 2024
Signed-off-by: jdupas22 <106673437+jdupas22@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants