Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SDK Publisher #291

Merged
merged 1 commit into from
Jul 20, 2022
Merged

fix: SDK Publisher #291

merged 1 commit into from
Jul 20, 2022

Conversation

flemzord
Copy link
Member

Fix for SDK Publisher

Please add a description to this PR.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Technical debt

What parts of the code are impacted ?

Please describe the impacted parts of the code.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #291 (666ea96) into main (3e0f91b) will increase coverage by 0.20%.
The diff coverage is 100.00%.

❗ Current head 666ea96 differs from pull request most recent head db31f10. Consider uploading reports for the commit db31f10 to get more accurate results

@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
+ Coverage   71.85%   72.05%   +0.20%     
==========================================
  Files          82       82              
  Lines        4302     4305       +3     
==========================================
+ Hits         3091     3102      +11     
+ Misses        936      931       -5     
+ Partials      275      272       -3     
Impacted Files Coverage Δ
pkg/core/log.go 83.13% <100.00%> (+0.63%) ⬆️
pkg/core/transaction.go 75.51% <100.00%> (+5.51%) ⬆️
pkg/ledger/process.go 84.21% <100.00%> (ø)
pkg/storage/sqlstorage/log.go 78.70% <100.00%> (+1.78%) ⬆️
pkg/storage/sqlstorage/transactions.go 85.79% <100.00%> (ø)
pkg/analytics/segment.go 90.62% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90143b0...db31f10. Read the comment docs.

@flemzord flemzord marked this pull request as ready for review July 20, 2022 09:18
@flemzord flemzord merged commit 86502a0 into main Jul 20, 2022
@flemzord flemzord deleted the fix/sdk branch July 20, 2022 09:36
flemzord added a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants