Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make logs store only the payload of the write action #295

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

gfyrag
Copy link
Contributor

@gfyrag gfyrag commented Jul 21, 2022

Make logs store only the payload of the write action

Also, add a migration to alter logs with invalid fields preCommitVolumes and postCommitVolumes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Technical debt

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #295 (6dfd34a) into main (490082a) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   71.67%   71.82%   +0.14%     
==========================================
  Files          84       86       +2     
  Lines        4548     4739     +191     
==========================================
+ Hits         3260     3404     +144     
- Misses        991     1028      +37     
- Partials      297      307      +10     
Impacted Files Coverage Δ
pkg/core/log.go 88.67% <100.00%> (+7.14%) ⬆️
pkg/analytics/segment.go 57.26% <0.00%> (-27.12%) ⬇️
pkg/storage/driver.go 22.22% <0.00%> (-6.35%) ⬇️
cmd/root.go 88.77% <0.00%> (-0.23%) ⬇️
cmd/internal/utils.go 100.00% <0.00%> (ø)
cmd/internal/analytics.go 80.95% <0.00%> (ø)
pkg/api/internal/testing.go 91.48% <0.00%> (+0.23%) ⬆️
pkg/ledger/resolver.go 84.48% <0.00%> (+0.27%) ⬆️
pkg/ledger/process.go 86.36% <0.00%> (+0.64%) ⬆️
pkg/ledger/ledger.go 69.76% <0.00%> (+0.96%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gfyrag gfyrag force-pushed the feature/num-640-ledger-clean-logs branch from d5bffe7 to c26a9f4 Compare July 26, 2022 21:16
Base automatically changed from feature/remove-triggers to main August 1, 2022 13:36
@gfyrag gfyrag force-pushed the feature/num-640-ledger-clean-logs branch from c26a9f4 to 4f1523d Compare August 1, 2022 13:43
Also, add a migration to alter logs with invalid fields preCommitVolumes and postCommitVolumes.
@gfyrag gfyrag force-pushed the feature/num-640-ledger-clean-logs branch from 4f1523d to 61aef48 Compare August 1, 2022 14:22
@gfyrag gfyrag marked this pull request as ready for review August 1, 2022 14:23
@gfyrag gfyrag requested a review from a team as a code owner August 1, 2022 14:23
jdupas22
jdupas22 previously approved these changes Aug 5, 2022
antoinegelloz
antoinegelloz previously approved these changes Aug 30, 2022
…#292)

* feat: Add a log processor to compute the expected model reading logs.

* fix: tests
@gfyrag gfyrag dismissed stale reviews from antoinegelloz and jdupas22 via 6dfd34a August 30, 2022 19:49
@gfyrag gfyrag merged commit db9d89b into main Aug 31, 2022
@gfyrag gfyrag deleted the feature/num-640-ledger-clean-logs branch August 31, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants