Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change the order of UNSUFFICIENT_FUNDS and CONFLICT errors #302

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

gfyrag
Copy link
Contributor

@gfyrag gfyrag commented Jul 25, 2022

Change the order of UNSUFFICIENT_FUNDS and CONFLICT errors

Instead of handling conflict errors at store level (by interpreting error codes from the database server), we check potential reference conflict at core level.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Technical debt

@gfyrag gfyrag force-pushed the feature/num-680-change-the-order-of-unsufficient_funds branch from 08ec794 to fc056cc Compare July 25, 2022 21:19
@gfyrag gfyrag marked this pull request as ready for review July 25, 2022 21:21
@gfyrag gfyrag requested a review from a team as a code owner July 25, 2022 21:21
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #302 (52a2dce) into main (c510cfa) will decrease coverage by 0.07%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
- Coverage   72.05%   71.97%   -0.08%     
==========================================
  Files          82       82              
  Lines        4387     4393       +6     
==========================================
+ Hits         3161     3162       +1     
- Misses        946      952       +6     
+ Partials      280      279       -1     
Impacted Files Coverage Δ
pkg/ledger/ledger.go 70.94% <0.00%> (-0.97%) ⬇️
pkg/ledger/process.go 84.26% <80.00%> (-0.55%) ⬇️
pkg/storage/storage.go 44.77% <0.00%> (-10.45%) ⬇️
pkg/analytics/segment.go 90.62% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c510cfa...52a2dce. Read the comment docs.

@gfyrag gfyrag force-pushed the feature/num-680-change-the-order-of-unsufficient_funds branch from f845d12 to 52a2dce Compare July 26, 2022 07:37
Copy link
Contributor

@antoinegelloz antoinegelloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@gfyrag gfyrag merged commit a8a47f0 into main Jul 26, 2022
@gfyrag gfyrag deleted the feature/num-680-change-the-order-of-unsufficient_funds branch July 26, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants