-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: New kafka message model & bump dependencies #319
chore: New kafka message model & bump dependencies #319
Conversation
Codecov Report
@@ Coverage Diff @@
## main #319 +/- ##
==========================================
- Coverage 71.57% 71.36% -0.21%
==========================================
Files 83 84 +1
Lines 4608 4641 +33
==========================================
+ Hits 3298 3312 +14
- Misses 1004 1023 +19
Partials 306 306
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only required changes is the storage part with the "fmt.Errorf()" calls.
I would like to know about the other points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Published events are double encoded
New kafka message model & bump dependencies
version
andapp
fields at the root of kafka messagesledger
field in the payload (keep the originalledger
field at the root of the messages for compatibility)Type of change
What parts of the code are impacted ?
pkg/bus
Checklist: