Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: New kafka message model & bump dependencies #319

Merged
merged 18 commits into from
Sep 1, 2022

Conversation

antoinegelloz
Copy link
Contributor

@antoinegelloz antoinegelloz commented Aug 25, 2022

New kafka message model & bump dependencies

  • Add version and app fields at the root of kafka messages
  • Add ledger field in the payload (keep the original ledger field at the root of the messages for compatibility)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Technical debt

What parts of the code are impacted ?

pkg/bus

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@antoinegelloz antoinegelloz requested a review from a team as a code owner August 25, 2022 14:38
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #319 (27a8d20) into main (bbd082a) will decrease coverage by 0.20%.
The diff coverage is 54.28%.

@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
- Coverage   71.57%   71.36%   -0.21%     
==========================================
  Files          83       84       +1     
  Lines        4608     4641      +33     
==========================================
+ Hits         3298     3312      +14     
- Misses       1004     1023      +19     
  Partials      306      306              
Impacted Files Coverage Δ
pkg/bus/message.go 50.00% <50.00%> (ø)
pkg/bus/monitor.go 67.34% <52.94%> (-5.57%) ⬇️
pkg/ledger/monitor.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@antoinegelloz antoinegelloz changed the title refactor: Move kafka messages models to sharedpublishkafka refactor: Expose kafka messages models and bump dependencies Aug 26, 2022
@antoinegelloz antoinegelloz changed the title refactor: Expose kafka messages models and bump dependencies chore: Expose kafka messages models and bump dependencies Aug 26, 2022
Copy link
Contributor

@gfyrag gfyrag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only required changes is the storage part with the "fmt.Errorf()" calls.

I would like to know about the other points.

@antoinegelloz antoinegelloz marked this pull request as draft August 29, 2022 08:45
@antoinegelloz antoinegelloz marked this pull request as ready for review August 29, 2022 10:16
@antoinegelloz antoinegelloz marked this pull request as draft August 29, 2022 10:16
@antoinegelloz antoinegelloz marked this pull request as ready for review August 29, 2022 10:26
@antoinegelloz antoinegelloz changed the title chore: Expose kafka messages models and bump dependencies chore: New kafka message model & bump dependencies Sep 1, 2022
jdupas22
jdupas22 previously approved these changes Sep 1, 2022
Copy link
Contributor

@gfyrag gfyrag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Published events are double encoded

@antoinegelloz antoinegelloz merged commit 1f8e2d8 into main Sep 1, 2022
@antoinegelloz antoinegelloz deleted the refactor/move-models-to-sharedpublishkafka branch September 1, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants