feat: denormalize addresses on transactions to improve read #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #351 +/- ##
==========================================
- Coverage 68.08% 67.94% -0.15%
==========================================
Files 93 93
Lines 5910 5961 +51
==========================================
+ Hits 4024 4050 +26
- Misses 1534 1562 +28
+ Partials 352 349 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
flemzord
commented
Oct 19, 2022
flemzord
changed the title
antoinegelloz
approved these changes
Oct 19, 2022
flemzord
added a commit
that referenced
this pull request
Oct 20, 2022
* wip: test to denormalize addresses on transactions to improve read performance * fix: sql insert * fix: extension init * fix: sqlite support * clean: some debug * fix: remove insertTransaction segfault protection Co-authored-by: Geoffrey Ragot <geoffrey.ragot@gmail.com> Co-authored-by: Antoine Gelloz <antoine.gelloz@me.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve transactions search
Currently, reading transactions filtering using account/source/destinations filters is pretty slow.
The queries has to unpack postings to be able to filter on them.
But this processing is quite consuming.
This PR add two new columns on transactions :
Both of these columns aggregate sources and destinations from all postings.
This way, the queries can rely on those columns directly instead of unpack postings.
Type of change