Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Script controller: conflict on reference & storage conflict error code 409 instead of 503 #360

Merged
merged 3 commits into from
Nov 9, 2022

Conversation

antoinegelloz
Copy link
Contributor

No description provided.

@antoinegelloz antoinegelloz requested review from altitude, flemzord and a team November 9, 2022 14:11
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #360 (fd836ca) into release/v1.7.0 (8b23500) will increase coverage by 0.12%.
The diff coverage is 66.66%.

@@                Coverage Diff                 @@
##           release/v1.7.0     #360      +/-   ##
==================================================
+ Coverage           69.79%   69.91%   +0.12%     
==================================================
  Files                  84       84              
  Lines                5347     5352       +5     
==================================================
+ Hits                 3732     3742      +10     
+ Misses               1315     1312       -3     
+ Partials              300      298       -2     
Impacted Files Coverage Δ
pkg/api/controllers/script_controller.go 83.33% <63.63%> (-2.39%) ⬇️
pkg/api/controllers/base_controller.go 73.17% <100.00%> (ø)
pkg/ledger/executor.go 64.42% <0.00%> (+2.88%) ⬆️
pkg/storage/storage.go 50.70% <0.00%> (+5.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@antoinegelloz antoinegelloz changed the title fix: Script controller: conflict on reference fix: Script controller: conflict on reference & storage conflict error code 409 instead of 503 Nov 9, 2022
@flemzord flemzord merged commit 6b265ba into release/v1.7.0 Nov 9, 2022
@flemzord flemzord deleted the v1.7.7 branch November 9, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants