Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename route GET /log to /logs #418

Merged
merged 5 commits into from
Jan 26, 2023

Conversation

antoinegelloz
Copy link
Contributor

No description provided.

@antoinegelloz antoinegelloz requested a review from a team January 26, 2023 14:55
@antoinegelloz antoinegelloz changed the base branch from main to fix/ristretto-cache-init-modification January 26, 2023 14:55
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #418 (e45f139) into fix/ristretto-cache-init-modification (42e1b20) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@                            Coverage Diff                            @@
##           fix/ristretto-cache-init-modification     #418      +/-   ##
=========================================================================
- Coverage                                  68.80%   68.72%   -0.08%     
=========================================================================
  Files                                         94       94              
  Lines                                       6511     6511              
=========================================================================
- Hits                                        4480     4475       -5     
- Misses                                      1647     1651       +4     
- Partials                                     384      385       +1     
Impacted Files Coverage Δ
pkg/api/internal/testing.go 88.83% <100.00%> (ø)
pkg/api/routes/routes.go 92.10% <100.00%> (ø)
pkg/analytics/segment.go 54.07% <0.00%> (-3.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gfyrag
gfyrag previously approved these changes Jan 26, 2023
Base automatically changed from fix/ristretto-cache-init-modification to main January 26, 2023 15:22
Signed-off-by: Maxence Maireaux <maxence@maireaux.fr>
@flemzord flemzord merged commit 8edd8c5 into main Jan 26, 2023
@flemzord flemzord deleted the chore/rename-route-get-log-to-logs branch January 26, 2023 15:24
flemzord added a commit that referenced this pull request Jan 26, 2023
* fix: first

* fix: cache capacity to 100 numscripts

* fix: flag name

* chore: first

Signed-off-by: Maxence Maireaux <maxence@maireaux.fr>
Co-authored-by: Maxence Maireaux <maxence@maireaux.fr>
flemzord added a commit that referenced this pull request Dec 4, 2023
Co-authored-by: Maxence Maireaux <maxence@maireaux.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants