-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Performance problems #419
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
antoinegelloz
commented
Jan 27, 2023
•
edited
Loading
edited
- fixed a bug where a new logger was created at each request, replacing the previous one with wrapped version, creating a exponential performance problem.
- fine tuned the Numscript cache system; The cost of each Numscript stored in cache is now calculated in bytes; The config can be modified with new flags.
- improved TxsToScriptData method predictability; Postings now always generate the same Numscript (variables declarations list was not always sorted)
- telemetry improvements
Codecov Report
@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 68.72% 68.98% +0.25%
==========================================
Files 94 95 +1
Lines 6511 6522 +11
==========================================
+ Hits 4475 4499 +24
+ Misses 1651 1638 -13
Partials 385 385
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* feat: add traces * test: remove logging * fix: remove logger context id key * fix: comment tests * test: Remove logs for cache * feat: disable sql traces * feat: commit transactions before write responses * fix: request id in logs and set sql traces only in debug mode * feat: clean spans --------- Co-authored-by: Ragot Geoffrey <geoffrey.ragot@gmail.com>
antoinegelloz
changed the title
fix: TxsToScriptData improved predictability
fix: Performance problems
Jan 30, 2023
gfyrag
previously approved these changes
Jan 30, 2023
gfyrag
approved these changes
Jan 30, 2023
flemzord
approved these changes
Jan 30, 2023
flemzord
added a commit
that referenced
this pull request
Jan 30, 2023
* chore: first * fix: cleanup * fix: improve cache config * feat: add some traces (#420) * fix: improve cache config * feat: add traces (#422) * feat: add traces * test: remove logging * fix: remove logger context id key * fix: comment tests * test: Remove logs for cache * feat: disable sql traces * feat: commit transactions before write responses * fix: request id in logs and set sql traces only in debug mode * feat: clean spans --------- Co-authored-by: Ragot Geoffrey <geoffrey.ragot@gmail.com> * fix: cleanup * chore: numscript cache testing --------- Co-authored-by: Ragot Geoffrey <geoffrey.ragot@gmail.com> Co-authored-by: Maxence Maireaux <maxence@maireaux.fr>
This was referenced Feb 22, 2023
Merged
Merged
flemzord
pushed a commit
that referenced
this pull request
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.