Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: asset format #426

Merged
merged 1 commit into from
Jan 31, 2023
Merged

fix: asset format #426

merged 1 commit into from
Jan 31, 2023

Conversation

gfyrag
Copy link
Contributor

@gfyrag gfyrag commented Jan 31, 2023

No description provided.

@gfyrag gfyrag changed the base branch from main to fix/num-1465-ledger-mappings-not-working-anymore January 31, 2023 15:03
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #426 (af9b14d) into main (871d69e) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
- Coverage   69.38%   69.30%   -0.08%     
==========================================
  Files          95       95              
  Lines        6522     6522              
==========================================
- Hits         4525     4520       -5     
- Misses       1613     1617       +4     
- Partials      384      385       +1     
Impacted Files Coverage Δ
pkg/core/asset.go 100.00% <ø> (ø)
pkg/analytics/segment.go 54.07% <0.00%> (-3.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

antoinegelloz
antoinegelloz previously approved these changes Jan 31, 2023
Base automatically changed from fix/num-1465-ledger-mappings-not-working-anymore to main January 31, 2023 16:51
@flemzord flemzord merged commit 1345154 into main Jan 31, 2023
@flemzord flemzord deleted the fix/asset-format branch January 31, 2023 17:37
flemzord pushed a commit that referenced this pull request Jan 31, 2023
fix: asset format (not allowing single char)
gfyrag added a commit that referenced this pull request Feb 9, 2023
fix: asset format (not allowing single char)
flemzord pushed a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants