Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic reverse transaction logic #59

Closed
wants to merge 4 commits into from

Conversation

matiasinsaurralde
Copy link
Contributor

Based on specs defined in #52, simple tests included.
I've added a very basic HTTP handler for this action, we should ensure that errors are properly handled on a separate ticket (seems it can be improved in other handlers too).
Meta fields are still missing.

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #59 (6720889) into main (d43e6f5) will increase coverage by 0.13%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   33.91%   34.04%   +0.13%     
==========================================
  Files          26       26              
  Lines        1374     1404      +30     
==========================================
+ Hits          466      478      +12     
- Misses        857      875      +18     
  Partials       51       51              
Impacted Files Coverage Δ
api/http.go 0.00% <0.00%> (ø)
ledger/query/query.go 55.26% <0.00%> (-4.74%) ⬇️
core/transaction.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f49862a...6720889. Read the comment docs.

@altitude altitude closed this Nov 9, 2021
gfyrag pushed a commit that referenced this pull request Feb 23, 2023
flemzord pushed a commit that referenced this pull request Mar 27, 2023
flemzord pushed a commit that referenced this pull request Apr 18, 2023
flemzord pushed a commit that referenced this pull request Sep 20, 2023
flemzord pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants