Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9280 removed outdated test #5905

Merged
merged 1 commit into from
Nov 14, 2024
Merged

FIO-9280 removed outdated test #5905

merged 1 commit into from
Nov 14, 2024

Conversation

HannaKurban
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9280

Description

Since the value property check has been removed from the Use tab and the ValueProperty check is triggered only when User trying to save SelectBoxes component in the FormBuilder, the test is outdated. Instead, tests have been added to check the Value Property in the core library

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

tests pass locally

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit 854241f into master Nov 14, 2024
5 checks passed
@brendanbond brendanbond deleted the FIO-9280-fixing-tests branch November 14, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants