Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9217 Fix: allow moment.js datetime custom default values in calendar widget-text field components #5907

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

blakekrammes
Copy link
Contributor

@blakekrammes blakekrammes commented Nov 14, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9217

Description

When attempting to populate a text field component with a calendar widget with a custom default value that is a moment.js datetime the value eventually renders as empty string after initially rendering as the correct value. For some reason the default mask in component.js was being set to an empty array in this scenario.

What changed?

Check for empty array in component.js to avoid erroneously setting the default value to an empty string.

Why have you chosen this solution?

It was minimally invasive and is a check that should be in place already. If we don't have any masks in the default masks array, we don't want to treat it like we do have a mask. Empty arrays in JS evaluate as true, but we only want to execute the code if we actually have a mask. It's also worth noting that I believe the empty default mask array was being created in TextField.js's setInputMask method.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

Manual + automated

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

…dar widget-text field components

- For some reason the default mask was being set to an empty array  for this scenario
@TanyaGashtold TanyaGashtold merged commit 6f6d5bb into master Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants