Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9339: fixed an issue where preview shows an error when editing component JSON #5947

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

TanyaGashtold
Copy link
Contributor

@TanyaGashtold TanyaGashtold commented Dec 12, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9339

Description

What changed?

This PR fixes an issue where the preview shows an error instead of the component when the component settings are opened in the JSON mode. When the component is edited in JSON mode, the component settings are stored not on the top level of the edit form submission data, but inside the componentJson property of the data. This PR add this case.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit 74aadbb into master Dec 12, 2024
5 checks passed
@brendanbond brendanbond deleted the FIO-9339-fixed-preview-when-editing-json branch December 12, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants