Key with array index saves as object unless array already exists #706

philjolly · 2016-08-18T17:38:26Z

If i use a key that contains an array index i.e. things[0].stuff it will only save as an array if i have manually added an empty array to the model before a value is entered. If the parent node is empty it saves as an object with a key of "0".

http://jsbin.com/giwihenoyi/edit?html,js,output

philjolly · 2016-08-18T20:10:03Z

~~Well nevermind... as I started picking through the code to see if I could find a fix I realized its an issue with angular.$parse and they wont fix it... angular/angular.js#9850 closing in frustration~~ Reopened issue to follow guidelines for a forthcoming PR

angular. does not (and will not angular/angular.js#9850) properly handle arrays in keys unless they have already been created in the model. This fix/feature adds a separate parser for these circumstances and a formlyConfig.extras flag to control its use. The flag is in place to minimize impact on current functionality of the setter. This is in support of formly-js#706

angular. does not (and will not angular/angular.js#9850) properly handle arrays in keys unless they have already been created in the model. This fix/feature adds a separate parser for these circumstances and a formlyConfig.extras flag to control its use. The flag is in place to minimize impact on current functionality of the setter. This is in support of #706

philjolly closed this as completed Aug 18, 2016

philjolly reopened this Aug 19, 2016

philjolly mentioned this issue Aug 19, 2016

feat(formly-field): Adds parser for keys that contain arrays #709

Merged

3 tasks

kentcdodds closed this as completed Jan 11, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Key with array index saves as object unless array already exists #706

Key with array index saves as object unless array already exists #706

philjolly commented Aug 18, 2016

philjolly commented Aug 18, 2016 •

edited

Loading

Key with array index saves as object unless array already exists #706

Key with array index saves as object unless array already exists #706

Comments

philjolly commented Aug 18, 2016

philjolly commented Aug 18, 2016 • edited Loading

philjolly commented Aug 18, 2016 •

edited

Loading