create helper window and add keyboard shortcuts - fix #7 #36
Conversation
| accelerator : 'CmdOrCtrl+/', | ||
| click() { options.openHelpWindow(); } | ||
| }, | ||
| { | ||
| label : 'Learn More', |
There was a problem hiding this comment.
when we're already here - can we drop this learn more?
And maybe link to github issues? -> Report a problem
|
@radibit Man, nice PR. Things I'd like to document as well.
Not sure if grouping by panel makes sense... But it was like this in my head somehow. :) Overall - really really nice. 👍 |
|
|
||
| <dl class="c-help--definitionList"> | ||
| <dt> | ||
| <span class="c-help--key">←</span> |
There was a problem hiding this comment.
a definition list without words...
Maybe we can use aria-label here?
|
@stefanjudis Please have a look on the changes we discussed and if they are acceptable as part of this PR :) |
|
@radibit your build failed. :)
Just fiddled around a bit... What do you think, it looks a bit cleaner and saves space. Uups... has to be And left arrow on project code be Bonus: Can you please add the "Report a problem" menu entry? And a rebase with one sweet commit would be cool. :) |
# Conflicts: # app/electron.js
…rrest into feature/7-add-helper-menu
…hed commits) Squashed commits: [59e6cef] change the style of the help window - #7 [3e49a8e] set initial loading color - fix #38 [cecf3bf] create groups for the help page - fix #7 [25262c0] add scroll container to settings panel - fix #35 [6cfe020] apply changes from the CR - #7 [e09db23] create helper window and add keyboard shortcuts - fix #7
…rrest into feature/7-add-helper-menu
|
@stefanjudis after applying all the changes and fixing reported issues, I tried to squash all the commits, but unfortunately I can't see all the selected commits as one, though the operation was successful :/ I'd be happy if you can share what actually is preventing me of merging them. Also please verify and confirm the latest changes, hope we reached the desired state :) |
| height : 625, | ||
| width : 625, | ||
| height : 400, | ||
| width : 550, |
There was a problem hiding this comment.
@radibit This was a missunderstanding. Was too lazy in sketch to adjust that. :)
There was a problem hiding this comment.
yeah, no problem I was thinking the same, but was not sure if we want to add more info now.
|
to keep commit history clean i opened #40 and squashed everything there. |
This PR provides solution for the following two items:
shortcutsor anythingIn addition I extracted some repeated visual elements into components, following the proper namespace.
I'm open for suggestions for the actual content for the help window :)