Get electrs source tarball with gpg verified sha256 and corresponding helper script #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixbitcoin
force-pushed
the
electrs-sha256
branch
from
0862277 to
b47b785
Compare
|
Here are a few patches that I think are sensible. What was the reason for the |
nixbitcoin
force-pushed
the
electrs-sha256
branch
2 times, most recently
from
f1e367a to
b47b785
Compare
|
Wow, thank you. I learned so much from your commits. Truly much better with your changes. The reason for |
|
Re: 90f3f35 |
|
Regarding |
I get this when removing
|
|
I can't reproduce the error when removing |
|
I'm deploying from the When using your version without I get error
|
|
Ah, the error appears when building the electrs pkg pinned to nixpkgs-unstable that's used in the modules: This bug has been fixed in the current |
nixbitcoin
added a commit
to nixbitcoin/nix-bitcoin
that referenced
this pull request
Apr 17, 2020
Specifically to advance fort-nix#156 without cargoDepsHook
|
LGTM. Can you squash the fixup commits and put the |
|
With I tried changing clang to a newer version with -{ lib, rustPlatform, clang, llvmPackages, fetchurl, pkgs }:
+{ lib, rustPlatform, llvmPackages_10, fetchurl, pkgs }:
rustPlatform.buildRustPackage rec {
pname = "electrs";
version = "0.8.3";
@@ -10,8 +10,8 @@ rustPlatform.buildRustPackage rec {
};
# Needed for librocksdb-sys
- buildInputs = [ clang ];
- LIBCLANG_PATH = "${llvmPackages.libclang}/lib";
+ buildInputs = [ llvmPackages_10.clang ];
+ LIBCLANG_PATH = "${llvmPackages_10.libclang}/lib";But still got the error I think it's somehow related to romanz/electrs#226 and NixOS/nixpkgs@dc3c338#diff-0c4100e0613807f5600eb55c5446b20e but can't figure out how. Maybe you have an idea. |
nixbitcoin
force-pushed
the
electrs-sha256
branch
2 times, most recently
from
82e5d87 to
7f8e452
Compare
… helper script move script to pkg dir, add hint to script in pkg def remove unneeded script deps add extended bash error checking rename DIR -> TMPDIR remove TMPDIR on exit strip whitespace, simplify comments gpg2 -> gpg latesttagelectrs -> latest tmpdir: don't use XDG_RUNTIME_DIR XDG_RUNTIME_DIR is often in RAM and shouldn't be used for larger workloads like repo downlaods verify fingerprint of the imported key remove trailing '-' in output simplify output Hide --fetch-key output Output is not relevant to user, looks better without it More accurately describe ./get-sha256 function User might think that ./get-sha256 automatically updates sha256 in default.nix Fetch key from sks keyservers instead of keybase.io Using --recv-key simplifies getting the right key, and only the right key, greatly. I try to refrain from using sks keyservers, but the certificate spamming attack shouldn't be an issue in this case because we create a temporary keychain just for the verificaiton. remove unneeded cargoDepsHook Make clang nativeBuildInput instead of buildInput
nixbitcoin
force-pushed
the
electrs-sha256
branch
from
7f8e452 to
1acb22a
Compare
|
I was finally able to fix the issue by making
Done |
|
The test currently times out because of the channel update. |
erikarvstedt
approved these changes
Apr 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the electrs expression to fetch sources from the releases archive with
fetchurlinstead offetchFromGitHub. This allows us to calculate the sha256 ahead of time and compare it with Roman Zeyde's gpg-signed git tags. I have provided a helper script to automate the process.Overall this should improve expression integrity, and I plan to implement this for all our packages where gpg verification is possible.