Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bindgen #152

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Update bindgen #152

merged 1 commit into from
Apr 6, 2021

Conversation

jethrogb
Copy link
Member

@jethrogb jethrogb commented Mar 11, 2021 •
edited
Loading

I took some time this week to make the necessary bindgen changes (rust-lang/rust-bindgen#2004 rust-lang/rust-bindgen#2006 rust-lang/rust-bindgen#2007). This PR updates the bindgen build to use that.

Breaking changes:

  • unnamed types are renamed
  • C-unions are now actual unions
    • the field accessor functions that used to exist are easy enough to add back
  • bitfields are done differently now
  • some fn-ptrs are now unsafe
  • some fns and fn-ptrs now take const pointers as arguments
  • havege.c and timing.c are now not compiled on non-unix platforms, i.e. SGX (probably wasn't working properly anyway)

Fixes #5 #14 #61 #72 #88 #121

This was referenced Mar 11, 2021
Closed
Closed
Closed
Closed
Closed
Closed
jethrogb
jethrogb commented Mar 11, 2021
View reviewed changes
mbedtls-sys/Cargo.toml Outdated Show resolved Hide resolved
@jethrogb jethrogb changed the base branch from master to acruceru/fix-cert-issue March 16, 2021 13:23
@jethrogb jethrogb force-pushed the update-bindgen branch 2 times, most recently from aad2e26 to 42e0865 Compare March 16, 2021 13:32
jethrogb
jethrogb commented Mar 16, 2021
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@AdrianCX AdrianCX force-pushed the acruceru/fix-cert-issue branch from be93f8f to 446e243 Compare March 23, 2021 09:40
Base automatically changed from acruceru/fix-cert-issue to master March 23, 2021 13:29
@jethrogb jethrogb changed the title [WIP] Update bindgen Update bindgen Mar 23, 2021
@jethrogb jethrogb requested a review from raoulstrackx March 23, 2021 14:04
@jethrogb jethrogb mentioned this pull request Mar 24, 2021
Closed
@jethrogb jethrogb force-pushed the update-bindgen branch 2 times, most recently from 0eac043 to 91bcf5e Compare March 25, 2021 11:43
@jethrogb

This comment has been minimized.

Sign in to view
@jethrogb jethrogb force-pushed the update-bindgen branch 2 times, most recently from 7da9574 to d0c7504 Compare April 6, 2021 06:41
@jethrogb
Copy link
Member Author

jethrogb commented Apr 6, 2021

This is ready for review now

raoulstrackx
raoulstrackx reviewed Apr 6, 2021
View reviewed changes
mbedtls-sys/build/bindgen.rs Outdated Show resolved Hide resolved
mbedtls-sys/build/bindgen.rs Outdated Show resolved Hide resolved
@raoulstrackx
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 6, 2021

Build succeeded:

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 9f17a9c into master Apr 6, 2021
shuwens added a commit to shuwens/rust-mbedtls that referenced this pull request Dec 1, 2021
@shuwens
https://github.com/fortanix/rust-mbedtls/pull/152
413a675
@zugzwang zugzwang mentioned this pull request Mar 13, 2023
Merged
@Taowyoo Taowyoo deleted the update-bindgen branch October 20, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raoulstrackx raoulstrackx raoulstrackx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade bindgen
2 participants
@jethrogb @raoulstrackx