Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unstable package-features after stabilization #311

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Remove unstable package-features after stabilization #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ matrix:
- rustup target add x86_64-fortanix-unknown-sgx x86_64-unknown-linux-musl
script:
- cargo test --verbose --all --exclude sgxs-loaders
- cargo test --verbose -p sgx-isa --features sgxstd -Z package-features --target x86_64-fortanix-unknown-sgx --no-run
- cargo test --verbose -p sgxs-tools --features pe2sgxs --bin isgx-pe2sgx -Z package-features
- cargo test --verbose -p dcap-ql --features link -Z package-features
- cargo test --verbose -p dcap-ql --features verify -Z package-features
- cargo test --verbose -p sgx-isa --features sgxstd --target x86_64-fortanix-unknown-sgx --no-run
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you use the new --features package/feature syntax?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, judging by the build success.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, misread your comment. Yes I can do that

- cargo test --verbose -p sgxs-tools --features pe2sgxs --bin isgx-pe2sgx
- cargo test --verbose -p dcap-ql --features link
- cargo test --verbose -p dcap-ql --features verify
- cargo build --verbose -p aesm-client --target=x86_64-fortanix-unknown-sgx
# NOTE: linking glibc version of OpenSSL with musl binary.
# Unlikely to produce a working binary, but at least the build succeeds.
Expand Down